Page MenuHomePhabricator

EventLogging: figure out differences between visitPage and click events
Closed, ResolvedPublic

Description

We recently updated our eventlogging to look at click events rather than just visitPage and we now have the original logging and the new logging but with very different results between the two.

This ticket is to investigate what we're logging, what changed and what might be the best to update it to in order to distinguish interwiki clicks correctly.

A suggestion from @EBernhardson:

the three extra parameter values that we have: we only need these on SERP events. they're actually redundant on the click events. this means that for click events, we can use the extra params field to have that interwiki boolean flag.

This work to be done is effectively blocking a lot of testing that we want to do on the Search team and specifically this: https://phabricator.wikimedia.org/T136017

Event Timeline

debt created this task.Jun 8 2016, 12:19 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 8 2016, 12:19 AM
debt triaged this task as High priority.Jun 8 2016, 12:20 AM
debt moved this task from needs triage to This Quarter on the Discovery-Search board.

Change 293424 had a related patch set uploaded (by EBernhardson):
search suggestions: Add tracking of highlight events

https://gerrit.wikimedia.org/r/293424

Change 293426 had a related patch set uploaded (by EBernhardson):
searchSatisfaction: Handle highlight event

https://gerrit.wikimedia.org/r/293426

Not sure the two linked patches resolve all problems, but they do resolve one case where click events were firing but not visitPage/checkin events: The case where a user selected an autocomplete result with the arrow keys and pressed enter.

@bearloga Are our problems with visitPage/click primarily with autocomplete, or are there problems with fulltext as well? I spent some time trying out things with fulltext but only found problems in the opposite direction (click events that wern't being sent.) The next patch linked here will be about fixing those, but they might only make the data collection look worse...

Change 293425 had a related patch set uploaded (by EBernhardson):
Fix two bugs in search satisfaction fulltext clicks not being recorded

https://gerrit.wikimedia.org/r/293425

Change 293426 abandoned by EBernhardson:
searchSatisfaction: Handle highlight event

Reason:
abandon in favor of normalizing click events into form submits and better submit handling.

https://gerrit.wikimedia.org/r/293426

Change 293424 abandoned by EBernhardson:
search suggestions: Add tracking of highlight events

Reason:
abandon in favor of normalizing clicks into form submits and better submit handling.

https://gerrit.wikimedia.org/r/293424

Change 293734 had a related patch set uploaded (by EBernhardson):
Add tests for search satisfaction event logging

https://gerrit.wikimedia.org/r/293734

Change 293425 merged by jenkins-bot:
Fix four bugs in search satisfaction fulltext clicks improperly recorded

https://gerrit.wikimedia.org/r/293425

Change 294772 had a related patch set uploaded (by EBernhardson):
Fix four bugs in search satisfaction fulltext clicks improperly recorded

https://gerrit.wikimedia.org/r/294772

Change 294772 merged by jenkins-bot:
Fix four bugs in search satisfaction fulltext clicks improperly recorded

https://gerrit.wikimedia.org/r/294772

Change 293734 merged by jenkins-bot:
Add tests for search satisfaction event logging

https://gerrit.wikimedia.org/r/293734

debt closed this task as Resolved.Jul 21 2016, 6:22 PM