Page MenuHomePhabricator

A bundle of more than 99 notifications shows as 100
Closed, ResolvedPublic

Description

Expected: 99+ new topics on PageA
Actual: 100 new topics on PageA

Event Timeline

SBisson created this task.Jun 8 2016, 12:42 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 8 2016, 12:42 PM
Catrope added a subscriber: Catrope.Jun 9 2016, 9:13 AM

Which message key is this? (You can find out using ?uselang=qqx.) The message I see in my local i18n file is correct:

"flow-notification-newtopic-bundle": "{{PLURAL:$1|One new topic|$1 new topics|100=99+ new topics}} on <strong><span class=\"plainlinks\">[$3 $2]</span></strong>",

Which message key is this? (You can find out using ?uselang=qqx.) The message I see in my local i18n file is correct:

"flow-notification-newtopic-bundle": "{{PLURAL:$1|One new topic|$1 new topics|100=99+ new topics}} on <strong><span class=\"plainlinks\">[$3 $2]</span></strong>",

This key is from the old system (notice the markup and the links).

It's notification-bundle-header-flow-new-topic, and notification-bundle-header-flow-new-topic-user-talk seems to have the same issue.

Catrope claimed this task.Jun 9 2016, 12:30 PM

Hah, looks like the 99+ changes changed the wrong messages then. Will fix.

Change 293496 had a related patch set uploaded (by Catrope):
Update messages referring to topics and replies for 99 changes in Echo

https://gerrit.wikimedia.org/r/293496

Change 293496 merged by jenkins-bot:
Update messages referring to topics and replies for 99 changes in Echo

https://gerrit.wikimedia.org/r/293496

Catrope closed this task as Resolved.Jun 9 2016, 1:47 PM