Investigate behavior of old frontend/backend when comments need moderation and state changes
Closed, ResolvedPublic5 Story Points

Description

Try out and read the old code what happens to the donation data when a user enters a comment that needs moderation.

  • Is the previous state somehow recorded?
  • When the donation is marked "OK" in the backend, what state is it set to?
  • Does the new state depend on payment type?
  • What happens when an external payment notification comes in (revisit T130190)?
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 8 2016, 1:57 PM
Lea_WMDE moved this task from Incoming to WMDE Fundraising on the TCB-Team board.Jun 8 2016, 3:04 PM
gabriel-wmde closed this task as Resolved.Jun 8 2016, 5:30 PM

Is the previous state somehow recorded?

Nope.

When the donation is marked "OK" in the backend, what state is it set to?

It's a bit more complicated because there are several status changes:

  1. "Locking": means marking for moderation status ("P").
  2. "Unlocking": the status gets restored, depending on payment state through getRecoveredStatus (N or E for direct debit, Z for bank transfer, X or B for external payment methods).
  3. "Deleting": Means marking with status deleted ("D")
  4. "Undeleting": the status gets restored, depending on payment state through getRecoveredStatus

Does the new state depend on payment type?

Yes, see above

What happens when an external payment notification comes in (revisit T130190)?

Can't test properly, but the old code checks if state was "moderated" or "deleted" before or if donation record doesn't pass the moderation filter, the "is_public" is set to false. Created T130190 to reflect this