Page MenuHomePhabricator
Create Task
Maniphest T137308

Investigate behavior of old frontend/backend when comments need moderation and state changes
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Try out and read the old code what happens to the donation data when a user enters a comment that needs moderation.

  • Is the previous state somehow recorded?
  • When the donation is marked "OK" in the backend, what state is it set to?
  • Does the new state depend on payment type?
  • What happens when an external payment notification comes in (revisit T130190)?

Related Objects
Search...

Event Timeline

gabriel-wmde created this task.Jun 8 2016, 1:57 PM
Restricted Application added subscribers: Zppix, • Aklapper. · View Herald TranscriptJun 8 2016, 1:57 PM
gabriel-wmde mentioned this in T137307: Check if comment needs moderation.Jun 8 2016, 1:58 PM
gabriel-wmde added a parent task: T137307: Check if comment needs moderation.
• Lea_WMDE moved this task from Incoming to WMDE Fundraising on the TCB-Team (now WMDE-TechWish) board.Jun 8 2016, 3:04 PM
gabriel-wmde closed this task as Resolved.Jun 8 2016, 5:30 PM

Is the previous state somehow recorded?

Nope.

When the donation is marked "OK" in the backend, what state is it set to?

It's a bit more complicated because there are several status changes:

  1. "Locking": means marking for moderation status ("P").
  2. "Unlocking": the status gets restored, depending on payment state through [[ https://github.com/wmde/fundraising-backend/blob/bf379296aef2a5ee702aacdc4c91261db6bfc065/application/model/Donation.php#L50-L73 | getRecoveredStatus ]] (N or E for direct debit, Z for bank transfer, X or B for external payment methods).
  3. "Deleting": Means marking with status deleted ("D")
  4. "Undeleting": the status gets restored, depending on payment state through getRecoveredStatus

Does the new state depend on payment type?

Yes, see above

What happens when an external payment notification comes in (revisit T130190)?

Can't test properly, but the old code checks if state was "moderated" or "deleted" before or if donation record doesn't pass the moderation filter, the "is_public" is set to false. Created T130190 to reflect this

gabriel-wmde moved this task from Ready-For-Campaign to Done on the WMDE-Fundraising-Frontend-Release board.Jun 8 2016, 5:31 PM
gabriel-wmde edited projects, added: WMDE-Fundraising-Frontend-Release; removed: WMDE-Fundraising-Frontend-Release (Ready-For-Campaign).
gabriel-wmde mentioned this in T130190: [WMDE-Fundraising] Trigger other data changes when changing donation status.Jun 8 2016, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits