Page MenuHomePhabricator

Move static assets to wheels
Closed, ResolvedPublic

Description

@Krinkle just pointed out that GUI of ores.wikimedia.org loads some js and css from labs. We should fix it.

Pull request: https://github.com/wiki-ai/ores/pull/149

See:

Event Timeline

Looks like we are pulling assets from https://wikimedia-ui.wmflabs.org/MW/mediawiki.min.css and https://munmay.github.io/WikimediaUI/MW/elements.html

Seems like both of these could come from the same sources that MediaWiki uses. @Krinkle, do you know of any sort of directory we can look through to find a better place to get them in prod?

Forgot to say, but of course we can just download them and make them assets of ORES. That would be sad, but not that sad.

https://github.com/wiki-ai/ores/pull/148 That would fix the most of it. We need some other things too

I started some work to see if we could wrap these assets in a wheel. I worked out that wrapping assets in a python project and then providing access to them via wheel works pretty well. See https://github.com/wiki-ai/ores/pull/149 and https://github.com/wiki-ai/flask-swaggerui

I filed a bug at WikimediaUI to ask about how to build from the repo. See https://github.com/munmay/WikimediaUI/issues/2 @Ladsgroup, do you know a good way to do this?

Halfak renamed this task from Move labs parts in GUI to its own loader to Move static assets to wheels.Jun 20 2016, 4:30 PM
Legoktm triaged this task as High priority.Jun 26 2016, 8:42 AM