Page MenuHomePhabricator

Allow empty show="" parameter for <mapframe> and <maplink>
Closed, ResolvedPublic

Description

It is sometimes fairly complicated to skip a template value on a parameter when using a {{#tag:mapframe | | <if ... then "show=..." else "nothing"> }}, so we should allow show= to be an empty value, to mean the same thing as no value. Same goes for the group=, and possibly other optional parameters. Note that text= without a value could have a specific meaning of "don't generate any HTML, but still add the geojson to the page's data".

Event Timeline

Yurik created this task.Jun 9 2016, 3:48 PM
Restricted Application added a project: Discovery. · View Herald TranscriptJun 9 2016, 3:48 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

Change 293655 had a related patch set uploaded (by MaxSem):
Don't error out on show=""

https://gerrit.wikimedia.org/r/293655

Change 293655 merged by jenkins-bot:
Don't error out on show=""

https://gerrit.wikimedia.org/r/293655

Yurik closed this task as Resolved.Jun 11 2016, 10:07 AM
Yurik claimed this task.