Page MenuHomePhabricator
Create Task
Maniphest T137509

Installer without mbstring installed fatals before the environment checklist
Closed, ResolvedPublic
Actions

Description

The top of Language.php has mb_internal_encoding( 'UTF-8' ); which is executed (and fatals) before the installer's environment checker kicks in.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move mbstring initializaton to Setup.php, add checksmediawiki/coremaster+7 -2
Move mbstring initializaton to Setup.php, add checksmediawiki/coreREL1_27+7 -2
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Jun 10 2016, 12:35 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 10 2016, 12:35 AM
MaxSem claimed this task.Jun 10 2016, 4:46 AM
Jdforrester-WMF merged a task: T137475: Installer uses mb_ extension before checking if it exists.Jun 10 2016, 8:33 AM
Jdforrester-WMF added subscribers: ProgrammingGen, Bawolff.
gerritbot subscribed.Jun 13 2016, 9:29 PM

Change 294172 had a related patch set uploaded (by MaxSem):
Move mbstring initializaton to Setup.php, add checks

https://gerrit.wikimedia.org/r/294172

gerritbot added a project: Patch-For-Review.Jun 13 2016, 9:29 PM
gerritbot added a comment.Jun 13 2016, 9:47 PM

Change 294177 had a related patch set uploaded (by MaxSem):
Move mbstring initializaton to Setup.php, add checks

https://gerrit.wikimedia.org/r/294177

gerritbot added a comment.Jun 13 2016, 9:58 PM

Change 294172 merged by jenkins-bot:
Move mbstring initializaton to Setup.php, add checks

https://gerrit.wikimedia.org/r/294172

ReleaseTaggerBot added a project: MW-1.27-release-notes.Jun 13 2016, 10:00 PM
gerritbot added a comment.Jun 13 2016, 10:01 PM

Change 294177 merged by jenkins-bot:
Move mbstring initializaton to Setup.php, add checks

https://gerrit.wikimedia.org/r/294177

• demon closed this task as Resolved.Jun 13 2016, 10:06 PM
ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 13 2016, 11:00 PM
Lucas_Werkmeister_WMDE mentioned this in T324202: Remove use of utf8_encode and utf8_decode in Wikibase.Dec 1 2022, 12:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits