Page MenuHomePhabricator

Special:Search input field has become smaller in Firefox
Closed, ResolvedPublic

Description

The change gerrit:292571, which introduced a "float: left" in order to fix T136945, has the potentially unwanted side-effect that the search input field has become a lot smaller in Firefox (but not in Chrome or IE/Edge).

Steps to reproduce:

(1) Open Special:Search in Chrome or IE/Edge and observe the "large" input field.
(2) Open Special:Search in Firefox and observe the "small" input field.
(3) Use developer tools to revert gerrit:292571 in Firefox and observe that the input field becomes "large" again.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 10 2016, 10:23 AM
Aklapper triaged this task as Normal priority.Jun 10 2016, 11:55 AM
Aklapper added a project: Regression.
Aklapper added a subscriber: Florian.
Entlinkt updated the task description. (Show Details)Jun 10 2016, 12:33 PM
Florian claimed this task.Jun 10 2016, 2:24 PM

Come on Firefox...

Come on Firefox...

In fact, the original cause is the poor design of the page. The "showing results x - y from z" should be actually bellow the form on top of the search results.

Change 293731 had a related patch set uploaded (by Florianschmidtwelzow):
Firefox: Explicit specifx the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/293731

Come on Firefox...

In fact, the original cause is the poor design of the page. The "showing results x - y from z" should be actually bellow the form on top of the search results.

  1. Actually I think Firefox renders it "correctly". I wonder why would we need "float" here.
  2. Agree with Danny

Change 294349 had a related patch set uploaded (by Bartosz Dziewoński):
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294349

Change 294349 merged by jenkins-bot:
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294349

matmarex closed this task as Resolved.Jun 14 2016, 4:32 PM
matmarex removed projects: Patch-For-Review, OOUI.
matmarex added a subscriber: matmarex.

I merged Florian's original patch, without the code for T38923 (what @Danny_B talks about above), which might result in more regressions. :)

Change 294511 had a related patch set uploaded (by Bartosz Dziewoński):
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294511

I'm cherry-picking the change to 1.28-wmf.6 to have it deployed to Wikimedia wikis this week, per the schedule at https://www.mediawiki.org/wiki/MediaWiki_1.28/Roadmap.

Change 294511 merged by jenkins-bot:
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294511