Special:Search input field has become smaller in Firefox
Closed, ResolvedPublic
Actions

Description

The change gerrit:292571, which introduced a "float: left" in order to fix T136945, has the potentially unwanted side-effect that the search input field has become a lot smaller in Firefox (but not in Chrome or IE/Edge).

Steps to reproduce:

(1) Open Special:Search in Chrome or IE/Edge and observe the "large" input field.
(2) Open Special:Search in Firefox and observe the "small" input field.
(3) Use developer tools to revert gerrit:292571 in Firefox and observe that the input field becomes "large" again.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Explicitly specify the width of the search input on Special:Search	mediawiki/core	master	+1 -0
	Explicitly specify the width of the search input on Special:Search	mediawiki/core	wmf/1.28.0-wmf.6	+1 -0

Customize query in gerrit

Related Objects

Mentioned Here: T38923: Special:Search pagination controls should be duplicated at top
T136945: Unnecessary line break for "result 1 to ..." on Special:Search

Event Timeline

Entlinkt created this task.Jun 10 2016, 10:23 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 10 2016, 10:23 AM

Raymond subscribed.Jun 10 2016, 10:28 AM

Sethakill added a project: MediaWiki-Special-pages.Jun 10 2016, 10:36 AM

Sethakill moved this task from To triage to Special:LinkSearch on the MediaWiki-Special-pages board.

Aklapper triaged this task as Medium priority.Jun 10 2016, 11:55 AM

Aklapper added a project: Regression.

Aklapper added a subscriber: Florian.

Krenair added a project: Browser-Support-Firefox.Jun 10 2016, 12:14 PM

Entlinkt updated the task description. (Show Details)Jun 10 2016, 12:33 PM

Entlinkt merged a task: T137548: Special:Search input field too narrow.Jun 10 2016, 1:01 PM

Entlinkt added a subscriber: Danny_B.

Entlinkt added projects: OOUI, UI-Standardization.Jun 10 2016, 1:09 PM

Entlinkt merged a task: T137553: Search field shrinking.Jun 10 2016, 1:36 PM

Entlinkt added subscribers: Amire80, eranroz, IKhitron.

Come on Firefox...

In T137535#2371788, @Florian wrote:

Come on Firefox...

In fact, the original cause is the poor design of the page. The "showing results x - y from z" should be actually bellow the form on top of the search results.

Change 293731 had a related patch set uploaded (by Florianschmidtwelzow):
Firefox: Explicit specifx the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/293731

gerritbot added a project: Patch-For-Review.Jun 10 2016, 2:30 PM

In T137535#2371806, @Danny_B wrote:

In T137535#2371788, @Florian wrote:

Come on Firefox...

In fact, the original cause is the poor design of the page. The "showing results x - y from z" should be actually bellow the form on top of the search results.

Actually I think Firefox renders it "correctly". I wonder why would we need "float" here.
Agree with Danny

Change 294349 had a related patch set uploaded (by Bartosz Dziewoński):
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294349

Change 294349 merged by jenkins-bot:
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294349

I merged Florian's original patch, without the code for T38923 (what @Danny_B talks about above), which might result in more regressions. :)

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)), MW-1.28-release-notes.Jun 14 2016, 5:00 PM

Change 294511 had a related patch set uploaded (by Bartosz Dziewoński):
Explicitly specify the width of the search input on Special:Search

https://gerrit.wikimedia.org/r/294511

gerritbot added a project: Patch-For-Review.Jun 15 2016, 3:48 PM

I'm cherry-picking the change to 1.28-wmf.6 to have it deployed to Wikimedia wikis this week, per the schedule at https://www.mediawiki.org/wiki/MediaWiki_1.28/Roadmap.

Change 294511 merged by jenkins-bot:
Explicitly specify the width of the search input on Special:Search