Maniphest T137595

Fix image widening and gallery not opening for some images bug by switching to desktop endpoint for all non Zero rated requests.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Jun 10 2016, 9:20 PM

Tags

Referenced Files

None

Subscribers

Description

Should we revert this???

Related Objects

Mentioned In: rAPIOSeb617f0a6fb9: Merge pull request #710 from wikimedia/bug/image-widening/T137595

Event Timeline

Mhurd created this task.Jun 10 2016, 9:20 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 10 2016, 9:20 PM

https://github.com/wikimedia/wikipedia-ios/pull/710

• Fjalapeno mentioned this in rAPIOSeb617f0a6fb9: Merge pull request #710 from wikimedia/bug/image-widening/T137595.Jun 11 2016, 12:04 AM

Do we want to keep or revert?

• JMinor triaged this task as High priority.Jun 14 2016, 6:29 AM

• JMinor added a project: iOS-app-Bugs.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

• Fjalapeno moved this task from Needs Code Review to Blocked or Waiting on the iOS-app-v5.0.5-Fever board.Jun 15 2016, 8:12 PM

@JMinor Hmmm… if its working, we can leave it in the bug fix build, but lets move the to 5.1 and decide if we will revert it

• Fjalapeno edited projects, added iOS-app-v5.1.0-Saturn; removed iOS-app-v5.0.5-Fever.Jun 16 2016, 8:24 PM

• Fjalapeno updated the task description. (Show Details)

• JMinor moved this task from Backlog to Needs Acceptance Criteria on the iOS-app-v5.1.0-Saturn board.Jun 20 2016, 6:33 PM

This was fixed by mobileview srcset change being reverted. We may still want to do this for consistency with Android.

Okay, probably good to future-proof and be consistant across clients, but a lower priority now that immediate issue is solved.

• JMinor moved this task from Needs Acceptance Criteria to Blocked or Waiting on the iOS-app-v5.1.0-Saturn board.Jul 11 2016, 7:25 PM

• JMinor removed a project: iOS-app-v5.1.0-Saturn.Aug 9 2016, 10:15 PM

• JMinor added a project: iOS-app-v5.5.0-Snake-On-A-Magic-Towel.Mar 21 2017, 11:10 PM

• JMinor closed this task as Resolved.Mar 23 2017, 8:58 PM