Page MenuHomePhabricator
Create Task
Maniphest T137608

Reinstate srcset for action=mobileview
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The Wikipedia Mobile for iOS app relies upon srcset in its image widening routine. srcset should be reinstated for action=mobileview so the app and older versions of the app continue to function normally with image widening and generally functional gallery support (invoked from image tap). The mobile website HTML pages should continue to strip srcset, though.

Related patches identified by @Mholloway:

https://gerrit.wikimedia.org/r/#/c/270793
https://gerrit.wikimedia.org/r/#/c/286502/
https://gerrit.wikimedia.org/r/#/c/287818/
https://gerrit.wikimedia.org/r/#/c/287794/

The fix should be verified in the app.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't strip srcset on API mobileview actionmediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.5+35 -2
Don't strip srcset on API mobileview actionmediawiki/extensions/MobileFrontendmaster+35 -2
Customize query in gerrit

Event Timeline

dr0ptp4kt created this task.Jun 10 2016, 11:14 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 10 2016, 11:14 PM
• bmansurov subscribed.Jun 10 2016, 11:19 PM
ori subscribed.EditedJun 10 2016, 11:34 PM

@dr0ptp4kt, are you suggesting that we reinstate them for plain web views as well?

dr0ptp4kt updated the task description. (Show Details)Jun 10 2016, 11:53 PM
• Fjalapeno added a comment.Jun 11 2016, 12:00 AM

@ori For iOS we just need and mobile view API responses to restore the srcsets.

• Fjalapeno added a project: Wikipedia-iOS-App-Backlog.Jun 11 2016, 12:00 AM
• Fjalapeno moved this task from Needs Triage to Tracking on the Wikipedia-iOS-App-Backlog board.
dr0ptp4kt updated the task description. (Show Details)Jun 11 2016, 12:31 AM
• brooke added a comment.Jun 11 2016, 12:36 AM

So if I'm reading correctly, the previous config hack was not disabling srcset in API requests, but did use the parser cache key tweak... thus mostly keeping the mobile app views similar to desktop parser cache and the mobile web views separate with their stripped srcset.

So, would need MobileFrontend hook to switch the srcset disabling back off in case it's inside the mobile view API request and I think it should pick up the right parser cache key.

gerritbot subscribed.Jun 11 2016, 1:26 AM

Change 293893 had a related patch set uploaded (by Brion VIBBER):
Don't strip srcset on API mobileview action

https://gerrit.wikimedia.org/r/293893

gerritbot added a project: Patch-For-Review.Jun 11 2016, 1:26 AM
gerritbot added a comment.Jun 11 2016, 6:04 PM

Change 293893 merged by jenkins-bot:
Don't strip srcset on API mobileview action

https://gerrit.wikimedia.org/r/293893

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 11 2016, 7:00 PM
phuedx moved this task from To Do to Code Review on the Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS board.Jun 13 2016, 9:24 AM
phuedx assigned this task to • Jhernandez.Jun 13 2016, 9:47 AM
phuedx added a comment.EditedJun 13 2016, 9:49 AM

@Jhernandez will be testing 293893: Don't strip srcset on API mobileview action and, hopefully, getting it SWAT deployed today.

gerritbot added a comment.Jun 13 2016, 9:53 AM

Change 294036 had a related patch set uploaded (by Jhernandez):
Don't strip srcset on API mobileview action

https://gerrit.wikimedia.org/r/294036

• Jhernandez added a comment.Jun 13 2016, 10:40 AM

Swat deploy added to calendar: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20160613T1500

I'd appreciate +1s and testing in https://gerrit.wikimedia.org/r/#/c/294036/ , I've added info on the patch comments about how to verify too.

gerritbot added a comment.Jun 13 2016, 2:44 PM

Change 294036 merged by jenkins-bot:
Don't strip srcset on API mobileview action

https://gerrit.wikimedia.org/r/294036

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 13 2016, 3:00 PM
• Jhernandez closed this task as Resolved.Jun 13 2016, 5:11 PM
• Jhernandez moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS board.

This has been swat deployed and works, confirmed by the iOS team crew and me in en.wiki

• Jhernandez removed a project: iOS-app-Bugs.Jun 13 2016, 5:12 PM
• Jhernandez set the point value for this task to 3.
• jhobs subscribed.Jun 13 2016, 5:41 PM
In T137608#2376716, @Jhernandez wrote:

This has been swat deployed and works, confirmed by the iOS team crew and me in en.wiki

Always include proof! ;)
IRC log:

IRC conversation from June 13th, 2016:

<coreyfloyd> joakino: so far so good. I'm mobile - in line at WWDC
joakino: but no problems in the app so far

<joakino> awesoemee

<mdholloway> if the iOS guys say it's working i'll defer to them ;)

<joakino> thanks all

<coreyfloyd> joakino: Joe also says it works

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits