Caching based on the input (pre-check) AbuseFilterVariableHolder vars as a key and using the existing onParserOutputStashForEdit hook could improve page save time. A large chunk of edits have no summary or the default section summary (and minoredit=0). Edits from (undo) links have a prefilled summary, so that can be known at stash time too.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | aaron | T136678 Investigate how to increase edit stash hit rate | |||
| Resolved | aaron | T137698 Plugin AbuseFilter::checkAllFilters pre-caching into the edit stash hook |
Event Timeline
Comment Actions
Change 294049 had a related patch set uploaded (by Aaron Schulz):
Send the edit summary/user to the edit stash API
Comment Actions
Change 294051 had a related patch set uploaded (by Aaron Schulz):
[WIP] Plugin AbuseFilter::checkAllFilters pre-caching into the edit stash hook
Comment Actions
Change 294049 merged by jenkins-bot:
Send the edit summary/user to the edit stash API
Comment Actions
Change 294051 merged by jenkins-bot:
Cache AbuseFilter::checkAllFilters during edit stashing
Comment Actions
Looks that change calls the check stash way too much causing regression in saving time. See T138550: 1.28.0-wmf.7 save time regression