Page MenuHomePhabricator

Plugin AbuseFilter::checkAllFilters pre-caching into the edit stash hook
Closed, ResolvedPublic

Description

Caching based on the input (pre-check) AbuseFilterVariableHolder vars as a key and using the existing onParserOutputStashForEdit hook could improve page save time. A large chunk of edits have no summary or the default section summary (and minoredit=0). Edits from (undo) links have a prefilled summary, so that can be known at stash time too.

Event Timeline

aaron created this task.Jun 13 2016, 11:03 AM

Change 294049 had a related patch set uploaded (by Aaron Schulz):
Send the edit summary/user to the edit stash API

https://gerrit.wikimedia.org/r/294049

Change 294051 had a related patch set uploaded (by Aaron Schulz):
[WIP] Plugin AbuseFilter::checkAllFilters pre-caching into the edit stash hook

https://gerrit.wikimedia.org/r/294051

Change 294049 merged by jenkins-bot:
Send the edit summary/user to the edit stash API

https://gerrit.wikimedia.org/r/294049

Change 294051 merged by jenkins-bot:
Cache AbuseFilter::checkAllFilters during edit stashing

https://gerrit.wikimedia.org/r/294051

aaron closed this task as Resolved.Jun 16 2016, 8:14 PM
hashar added a subscriber: hashar.

Looks that change calls the check stash way too much causing regression in saving time. See T138550: 1.28.0-wmf.7 save time regression