Page MenuHomePhabricator
Create Task
Maniphest T137723

System messages misplaced on login page ("Special:UserLogin")
Closed, ResolvedPublic
Actions

Description

  • MediaWiki 1.27.0-rc.1 (5462877) <s>1.27.0-rc.0 (f502a0c)</s>
  • PHP 5.6.22-0+deb8u1 (apache2handler) <s>5.6.20-0+deb8u1 (apache2handler)</s>
  • ConfirmAccounts REL1_27 (071b0df)

On "Special:Login" the location of the system message is misplaced. A live example can be seen by accessing sandbox.semantic-mediawiki.org. Also see the file I uploaded.

This is probably related to the new AuthManager as tracked generally with T110291 and specifically with T110451. I am not absolutely sure though.

Bildschirmfoto vom 2016-06-13 17:59:35.png (554×842 px, 72 KB)

Details

SubjectRepoBranchLines +/-
Fix FakeTemplate usage in LoginSignupSpecialPagemediawiki/coreREL1_27+2 -7
Fix FakeTemplate usage in LoginSignupSpecialPagemediawiki/coremaster+2 -7
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Jun 13 2016, 4:10 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 13 2016, 4:10 PM
Kghbln updated the task description. (Show Details)Jun 13 2016, 4:10 PM
Kghbln renamed this task from System messages misplaced on login page to System messages misplaced on login page ("Special:UserLogin").Jun 13 2016, 4:36 PM
gerritbot subscribed.Jun 15 2016, 3:44 PM

Change 294508 had a related patch set uploaded (by Gergő Tisza):
Fix FakeTemplate usage in LoginSignupSpecialPage

https://gerrit.wikimedia.org/r/294508

gerritbot added a project: Patch-For-Review.Jun 15 2016, 3:44 PM
Kghbln edited projects, added MW-1.27-release; removed MediaWiki-extensions-ConfirmAccount.Jun 15 2016, 3:50 PM
Kghbln added a subscriber: Tgr.

@Tgr Ah, so this was actually a core issue made visible by the ConfirmAccount extension. Thank you for the patch.

matmarex added a project: MediaWiki-General.Jun 15 2016, 3:54 PM
Kghbln assigned this task to Tgr.Jun 15 2016, 4:00 PM
Kghbln triaged this task as Medium priority.
Kghbln updated the task description. (Show Details)
Kghbln updated the task description. (Show Details)
Kghbln added a comment.Jun 15 2016, 4:02 PM

@Tgr Assigned to you since you should also receive the credit for your fix too. :)

gerritbot added a comment.Jun 15 2016, 4:06 PM

Change 294508 merged by jenkins-bot:
Fix FakeTemplate usage in LoginSignupSpecialPage

https://gerrit.wikimedia.org/r/294508

gerritbot added a comment.Jun 15 2016, 4:31 PM

Change 294520 had a related patch set uploaded (by Gergő Tisza):
Fix FakeTemplate usage in LoginSignupSpecialPage

https://gerrit.wikimedia.org/r/294520

Tgr closed this task as Resolved.Jun 15 2016, 4:32 PM
Tgr removed a project: Patch-For-Review.
gerritbot added a comment.Jun 15 2016, 4:40 PM

Change 294520 merged by jenkins-bot:
Fix FakeTemplate usage in LoginSignupSpecialPage

https://gerrit.wikimedia.org/r/294520

Kghbln awarded a token.Jun 15 2016, 4:51 PM
ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)), MW-1.27-release-notes.Jun 15 2016, 5:00 PM
MGChecker removed a project: MW-1.28-release-notes.Jun 15 2016, 7:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL