Maniphest T137764

Filter out empty data overlays
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JGirault
	Jun 14 2016, 12:57 AM

Tags

Referenced Files

None

Subscribers

Description

On wikivoyage the layers control dropdown has selectors for empty data layers.

This is because in wikitext we can specify show="group1, group2" and currently Kartographer code will create empty data layers for each one of them.

We should filter out data layers with no data.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Filter out empty data layers (fixup)	mediawiki/extensions/Kartographer	master	+1 -1
	Filter out empty data layers	mediawiki/extensions/Kartographer	master	+1 -1

Customize query in gerrit

Event Timeline

• JGirault created this task.Jun 14 2016, 12:57 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 14 2016, 12:57 AM

• JGirault moved this task from Backlog to In progress on the Maps-Sprint board.Jun 14 2016, 1:08 AM

Change 294212 had a related patch set uploaded (by JGirault):
Filter out empty data layers

https://gerrit.wikimedia.org/r/294212

gerritbot added a project: Patch-For-Review.Jun 14 2016, 1:09 AM

Change 294212 merged by jenkins-bot:
Filter out empty data layers

https://gerrit.wikimedia.org/r/294212

Change 294213 had a related patch set uploaded (by JGirault):
Filter out empty data layers (fixup)

https://gerrit.wikimedia.org/r/294213

Change 294213 merged by jenkins-bot:
Filter out empty data layers (fixup)

https://gerrit.wikimedia.org/r/294213

• JGirault closed this task as Resolved.Jun 14 2016, 1:21 AM

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 14 2016, 2:00 AM