Page MenuHomePhabricator
Create Task
Maniphest T137815

Mapframe does not display properly when placed inside a collapsible environment
Closed, ResolvedPublic
Actions

Description

Mapframe does not work properly when placed inside a collapsible environment. Only part of the map is shown on the left side. See example here:

https://ru.wikivoyage.org/wiki/User:Atsirlin/maps-div

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix mapframe not displaying properly when placed inside a collapsible container.mediawiki/extensions/Kartographermaster+12 -0
Fix mapframe not displaying properly when placed inside a collapsible container.mediawiki/extensions/Kartographerwmf/1.28.0-wmf.6+11 -0
Fix mapframe not displaying properly when placed inside a collapsible container.mediawiki/extensions/Kartographermaster+11 -0
Customize query in gerrit

Event Timeline

Atsirlin created this task.Jun 14 2016, 4:18 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 14 2016, 4:18 PM
Atsirlin triaged this task as Medium priority.Jun 14 2016, 4:19 PM
Yurik added projects: Maps, Maps-Sprint.Jun 14 2016, 4:20 PM
Yurik added a subscriber: • JGirault.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJun 14 2016, 4:20 PM
Yurik moved this task from All map-related tasks to Wiki-related on the Maps board.Jun 14 2016, 4:43 PM
• JGirault added a comment.Jun 15 2016, 1:41 AM

At first sight the situation seems to be a bit challenging: the map would require a map.invalidateSize() on expand, but it seems nothing in the code can notify us about the change in container's collapsed/expanded status...

As a consequence, I'm not sure where to put a hook and ask leaflet to redraw the map, but I'll keep poking my head around it.

Yurik moved this task from Backlog to To-do on the Maps-Sprint board.Jun 15 2016, 2:07 AM
Yurik raised the priority of this task from Medium to High.Jun 16 2016, 4:14 PM
gerritbot subscribed.Jun 16 2016, 9:08 PM

Change 294839 had a related patch set uploaded (by JGirault):
Fix mapframe not displaying properly when placed inside a collapsible container.

https://gerrit.wikimedia.org/r/294839

gerritbot added a project: Patch-For-Review.Jun 16 2016, 9:08 PM
• JGirault added a comment.Jun 16 2016, 9:19 PM

We could go a bit further and avoid creating maps that are hidden by default. Only instantiate the Leaflet map when the collapsed container expands. This would save some JS execution time on page load. I will create a ticket in the backlog.

gerritbot added a comment.Jun 16 2016, 9:21 PM

Change 294839 merged by jenkins-bot:
Fix mapframe not displaying properly when placed inside a collapsible container.

https://gerrit.wikimedia.org/r/294839

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)).Jun 16 2016, 10:00 PM
gerritbot added a comment.Jun 16 2016, 10:17 PM

Change 294856 had a related patch set uploaded (by Yurik):
Fix mapframe not displaying properly when placed inside a collapsible container.

https://gerrit.wikimedia.org/r/294856

gerritbot added a comment.Jun 16 2016, 10:23 PM

Change 294856 merged by jenkins-bot:
Fix mapframe not displaying properly when placed inside a collapsible container.

https://gerrit.wikimedia.org/r/294856

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 16 2016, 11:00 PM
Yurik closed this task as Resolved.Jun 16 2016, 11:07 PM
Yurik claimed this task.
Atsirlin reopened this task as Open.Aug 12 2016, 1:01 AM

I re-open this task, because there are problems with maps in the collapsible environment again. Check, for example:

https://ru.wikivoyage.org/wiki/Гродненская_область

and click on "Открыть карту". Only a small part in the top of the map is displayed.

Yurik added a comment.Aug 12 2016, 1:04 AM

Thanks @Atsirlin, must be some bug with our latest version. @JGirault could you take a look?

Atsirlin added a comment.Aug 16 2016, 4:44 AM

It is highly desirable to solve this problem ASAP, because it affects all pages on Russian Wikivoyage

gerritbot added a comment.Aug 16 2016, 8:08 PM

Change 305063 had a related patch set uploaded (by JGirault):
Fix mapframe not displaying properly when placed inside a collapsible container.

https://gerrit.wikimedia.org/r/305063

gerritbot added a comment.Aug 16 2016, 9:17 PM

Change 305063 merged by jenkins-bot:
Fix mapframe not displaying properly when placed inside a collapsible container.

https://gerrit.wikimedia.org/r/305063

MaxSem closed this task as Resolved.Aug 16 2016, 9:25 PM
MaxSem reassigned this task from Yurik to • JGirault.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits