Page MenuHomePhabricator
Create Task
Maniphest T137841

Improve how cross-wiki upload dialog deals with uploads blocked by AbuseFilter
Closed, ResolvedPublic
Actions

Description

We should test and improve how cross-wiki upload dialog deals with uploads blocked by AbuseFilter (inspired by https://commons.wikimedia.org/wiki/Commons:Administrators'_noticeboard#AbuseFilter_for_cross-wiki_uploads). We don't have any special handling, so it probably just displays some confusing obscure error message, like UploadWizard (T132866).

Details

SubjectRepoBranchLines +/-
mw.Upload.BookletLayout: Better handle error messages from AbuseFilter and TitleBlacklistmediawiki/coremaster+74 -45
mw.Upload.BookletLayout: Pass parameters to custom error messagesmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jun 14 2016, 7:16 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJun 14 2016, 7:16 PM
Restricted Application added subscribers: Zppix, Poyekhali, Steinsplitter, Aklapper. · View Herald Transcript
matmarex triaged this task as High priority.Jun 14 2016, 7:23 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJun 14 2016, 7:23 PM
matmarex mentioned this in T120867: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces).Jun 15 2016, 11:23 PM
matmarex added a comment.Jun 16 2016, 1:24 PM

For the "test" part: this indeed suffers from the same problem as UW.

pasted_file (300×513 px, 31 KB)

matmarex renamed this task from Test and improve how cross-wiki upload dialog deals with uploads blocked by AbuseFilter to Improve how cross-wiki upload dialog deals with uploads blocked by AbuseFilter.Jun 16 2016, 1:29 PM
matmarex added a subtask: T137961: Uploads blocked by AbuseFilter should be reported with a different error in the API than 'verification-error'.
zhuyifei1999 moved this task from Incoming to Uploading (UploadWizard, cross-wiki upload, chunked uploading and API) on the Commons board.Jun 19 2016, 4:32 AM
matmarex added a parent task: T138273: Make AbuseFilter support a filter for cross-wiki uploads.Jun 20 2016, 11:25 PM
Gunnex subscribed.Jun 21 2016, 8:58 AM
gerritbot subscribed.Jun 23 2016, 4:39 AM

Change 295610 had a related patch set uploaded (by Bartosz Dziewoński):
mw.Upload.BookletLayout: Better handle error messages from AbuseFilter and TitleBlacklist

https://gerrit.wikimedia.org/r/295610

gerritbot added a project: Patch-For-Review.Jun 23 2016, 4:39 AM
gerritbot added a comment.Jun 28 2016, 1:24 AM

Change 296362 had a related patch set uploaded (by Bartosz Dziewoński):
mw.Upload.BookletLayout: Pass parameters to custom error messages

https://gerrit.wikimedia.org/r/296362

gerritbot added a comment.Jun 29 2016, 6:18 PM

Change 296362 abandoned by Bartosz Dziewoński:
mw.Upload.BookletLayout: Pass parameters to custom error messages

Reason:
Squashed into https://gerrit.wikimedia.org/r/295610

https://gerrit.wikimedia.org/r/296362

Jdforrester-WMF moved this task from Untriaged to Needs code review on the Multimedia board.Jul 7 2016, 1:59 PM
gerritbot added a comment.Jul 11 2016, 7:38 PM

Change 295610 merged by jenkins-bot:
mw.Upload.BookletLayout: Better handle error messages from AbuseFilter and TitleBlacklist

https://gerrit.wikimedia.org/r/295610

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 11 2016, 8:00 PM
matmarex closed subtask T137961: Uploads blocked by AbuseFilter should be reported with a different error in the API than 'verification-error' as Resolved.Jul 12 2016, 2:33 PM
matmarex closed this task as Resolved.Jul 12 2016, 2:39 PM
matmarex removed a project: Patch-For-Review.
matmarex mentioned this in T138273: Make AbuseFilter support a filter for cross-wiki uploads.Jul 14 2016, 5:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL