On https://www.wikidata.org/wiki/Special:Nearby
Uncaught Error: Module "mediawiki.router" is not loaded.mw.loader.require @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Oc6TECKA:12574
(anonymous function) @ nearby.js?2cf37:4
(anonymous function) @ nearby.js?2cf37:116
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T136971 MW-1.28.0-wmf.6 deployment blockers | |||
| Resolved | None | T137919 [Regression] Uncaught Error: Module "mediawiki.router" is not loaded (on Special:Nearby) |
Potentially blocking 1.28.0-wmf.16 roll out (we have it on group0 and group1) T136971
on mobile wikidata, I get:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:178 Error: Unknown dependency: site Error: Unknown dependency: site
at sortDependencies (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:160:256)
at String.<anonymous> (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:161:230)
at Function.jQuery.extend.each (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:5:235)
at resolve (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:161:196)
at Object.mw.loader.using (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:171:124)
at Object.<anonymous> (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:163:251)
at fire (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:45:122)
at Object.self.add [as done] (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:45:656)
at Object.promise.always (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:46:874)
at runScript (https://m.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=Oc6TECKA:163:1)on Catalan Wikipedia, I also get the js error (router) in desktop view but mobile view is okay:
if i add / move "mediawiki.router" as a dependency in mobile.startup, then I don't have the error but Special:Nearby doesn't do anything (e.g. no api requests to search for nearby pages)
Special:Nearby also appears to do nothing on https://he.m.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%91%D7%A1%D7%91%D7%99%D7%91%D7%94 (in mobile view)
if i add / move "mediawiki.router" as a dependency in mobile.startup, then I don't have the error but Special:Nearby doesn't do anything (e.g. no api requests to search for nearby pages)
Special:Nearby also appears to do nothing on https://he.m.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%91%D7%A1%D7%91%D7%99%D7%91%D7%94 (in mobile view)
Since this is breaking mobile wikidata and desktop catalan wikipedia, marking this as UBN!
@dr0ptp4kt can you help get the right people looking here, please?
Change 294645 had a related patch set uploaded (by Bmansurov):
Add the missing dependencies
The patch has been scheduled for a SWAT deploy: https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=657278&oldid=657277
Change 294649 had a related patch set uploaded (by Bmansurov):
Add the missing dependencies
I've reviewed tested and merged the master patch. Going to test the wmf6 version now.
I have took on me to green light the deploy right now as an emergency fix. It has been tested on beta and there are leet mobile developers around to assist / verify etc.
Mentioned in SAL [2016-06-16T09:18:08Z] <hashar@tin> Synchronized php-1.28.0-wmf.6/extensions/MobileFrontend: MobileFrontend RL registration issue preventing Special:Nearby from working properly T137919 (duration: 00m 36s)
cc/ @bmansurov
We have done the deploy over Google Hangouts and all went fine. Having developers to confirm the fix works makes it quite trivial.
As a follow up, we quickly talked about opening a SWAT deployment window during European morning. I have poked Releng private list about it, we will see about organizing / opening such a slot!
As I'm currently only working European morning hours/attending any meetings in SF morning hours but I still have the capacity (and the privs!) to deploy, a European morning SWAT deployment window would be great.
Also, being able to watch and chat with @hashar while he was deploying was really instructive and it'd be great if we could do this more.
I'll work on making a 'real' proposal and floating it publicly. Stay tuned (warning, I'm working half-time, 20 hours/week, for a while so I'm slower than normal!)
Also, being able to watch and chat with @hashar while he was deploying was really instructive and it'd be great if we could do this more.
Awesome!