Prevent double-registration of map events
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Yurik
	Jun 16 2016, 12:05 AM

Description

Per IRC @Mattflaschen-WMF:

I don't see anything stopping [maplink/mapframe event handlers] from getting double-registered. wikipage.content can be fired more than once per page load, e.g. from VisualEditor.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Prevent double-registration of map events	mediawiki/extensions/Kartographer	master	+35 -3

Customize query in gerrit

Related Objects

Mentioned In: T279141: Discussion tools source mode should display navigation popups when enabled

Event Timeline

Yurik created this task.Jun 16 2016, 12:05 AM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJun 16 2016, 12:05 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

Yurik moved this task from Backlog to To-do on the Maps-Sprint board.Jun 16 2016, 12:06 AM

• Mattflaschen-WMF unsubscribed.Jun 16 2016, 1:22 AM

Yurik moved this task from All map-related tasks to Kartographer on the Maps board.Jun 16 2016, 10:40 PM

Yurik moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.Jun 16 2016, 11:06 PM

• JGirault claimed this task.Jul 11 2016, 11:44 PM

• JGirault added a subscriber: • Mattflaschen-WMF.

• Mattflaschen-WMF unsubscribed.Jul 12 2016, 1:07 AM

• JGirault moved this task from To-do to In progress on the Maps-Sprint board.Aug 8 2016, 6:42 PM

Change 303712 had a related patch set uploaded (by JGirault):
Prevent double-registration of map events

https://gerrit.wikimedia.org/r/303712

• JGirault moved this task from In progress to Needs review on the Maps-Sprint board.Aug 8 2016, 11:17 PM

Change 303712 merged by jenkins-bot:
Prevent double-registration of map events

https://gerrit.wikimedia.org/r/303712

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).Aug 9 2016, 12:00 AM

• JGirault closed this task as Resolved.Aug 9 2016, 12:57 AM