Page MenuHomePhabricator

Epic: Consolidate mobile styling code
Closed, InvalidPublic


Currently, our app CSS stylesheets are generated from sources in at least three different places:

  1. MobileFrontend;
  2. the MobileApp extension; and
  3. I believe the iOS app has some .less files living in its repo.

On Android we update our bundled CSS by firing up and updating mw-vagrant and manually running a shell script[1] as often as someone thinks to do it. I'm not sure what the update strategy is for the iOS app. The styles in the MobileApp extension don't get a lot of attention, and we're not really frontend web devs.

I believe it would improve cross-mobile-platform consistency and communication to keep all of our CSS styling code in one place. I propose that that place be MobileFrontend, since we're all ultimately dependent on it. I suspect that having the app(s)-specific code in the same repo would help the mobile web devs anticipate possible effects of changes on mobile apps and encourage discussion about upcoming changes. Consolidation could also work hand-in-hand with incorporating the kind of unit testing that Joaquin mentioned in the recent email thread about the iOS srcset regression.

What do you think?


Related Objects

Event Timeline

Mholloway renamed this task from Epic: Consolidate mobile stylesheets to Epic: Consolidate mobile styling code.Jun 17 2016, 3:09 AM
dr0ptp4kt triaged this task as Medium priority.Jun 22 2016, 4:15 PM

I've got a strawman patch in progress on this but I've gotta talk to @Fjalapeno about the handlful of .less files they're keeping in their repo before I push it.

Fjalapeno raised the priority of this task from Medium to Needs Triage.Jun 28 2016, 5:41 PM
Fjalapeno moved this task from Needs Triage to Tracking on the Wikipedia-iOS-App-Backlog board.

Change 296489 had a related patch set uploaded (by Mholloway):
Add app style resources from MobileApp

Change 296489 abandoned by Mholloway:
Add app style resources from MobileApp

Not happening (at least in the foreseeable future) for the reasons discussed on On the apps teams we should instead devise better ways of adding tests (potentially in MobileFrontend) where needed and getting timely updates to our bundled CSS in order to prevent breakage.