In T138037#2389059, @scfc wrote:I tested modules/labstore/files/create-dbusers's logic to find all users and servicegroups (print(all_users)), and a) it does not seem to include the user account fdamken or Fabian24d97 and b) the logic for calculating the home directory looks wrong:
def homedir(self): prefix = '/srv/project/%s' % self.project if self.kind == 'user': return os.path.join(prefix, 'home', self.name.lower()) else: return os.path.join( prefix, 'project', re.sub(r'^%s\.' % self.project, '', self.name.lower()) )For tool accounts, self.name is for example tools.wikilint, but for user accounts, self.name is for example Tim Landscheidt, so the logic will only work for user accounts with the same shell user name as the wiki user name.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| labstore: Fix home directory calculation for user accounts | operations/puppet | production | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • madhuvishy | T135931 Tool Labs users missing replica.my.cnf (tracking) | |||
| Resolved | scfc | T138103 Calculation of home directories is broken for users |
Event Timeline
Comment Actions
Change 295029 had a related patch set uploaded (by Tim Landscheidt):
labstore: Fix home directory calculation for user accounts
Comment Actions
Change 295029 merged by Yuvipanda:
labstore: Fix home directory calculation for user accounts