Page MenuHomePhabricator
Create Task
Maniphest T138286

"Refreshed" search bar moves up 1px when clicked
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

While I was reviewing @bmansurov's change for T134894, I noticed that the "refreshed" search bar moved up 1px when I clicked it.

reading-web-staging-firefox.gif (62×368 px, 156 KB)

Note well that:

  • I don't see this behaviour in Chrome (51.0.2704.84); and
  • I see this behaviour at all widths (mobile, tablet, and desktop)
  • Happens in stable and beta.

Example URL: http://reading-web-staging.wmflabs.org/wiki/Main_Page?useformat=mobile
Browser: Firefox (47.0), Safari (9.1.1)
OS: OS X El Capitan 10.11.5

Suggested testbed, portrait and landscape, LTR & RTL:

  • Android 2.3 Browser phone form factor
  • Android 4.x/5.x/6.x Chrome phone form factor
  • Android 4.x/5.x/6.x Chrome tablet form factor
  • iOS 9.3 iPhone
  • iOS 9.3 iPad
  • Opera mobile (not mini) Android 4+ phone form factor
  • UC browser (not mini) Android 4+ phone form factor
  • Windows 7.5 Phone IE
  • Desktop Firefox
  • Desktop Chrome
  • Desktop Safari
  • Internet Explorer 11

Note that iOS 8.4 is out of scope while device / testing service available, but iOS 9.3 is pretty close to iOS 8.4 for layout.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Avoid 1px jump when focus searchmediawiki/extensions/MobileFrontendmaster+31 -27
Customize query in gerrit

Related Objects
Search...

Event Timeline

phuedx created this task.Jun 21 2016, 11:00 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 21 2016, 11:00 AM
Peachey88 added a project: MobileFrontend.Jun 21 2016, 11:01 AM
phuedx updated the task description. (Show Details)Jun 21 2016, 11:02 AM
• Jhernandez triaged this task as High priority.Jun 21 2016, 5:10 PM
• Jhernandez added a project: Web-Team-Backlog-Archived.
• Jhernandez moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.
dr0ptp4kt added a project: Reading-Web-Sprint-76-Retrosprekfast.Jun 21 2016, 5:38 PM
dr0ptp4kt moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog-Archived board.
phuedx added a comment.Jun 22 2016, 9:16 AM

T134894 didn't introduce this bug, which is why I'm treating it as distinct.

Jdlrobson updated the task description. (Show Details)Jun 27 2016, 4:42 PM
Jdlrobson set the point value for this task to 2.
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-76-Retrosprekfast board.
dr0ptp4kt updated the task description. (Show Details)Jun 29 2016, 6:07 PM
dr0ptp4kt updated the task description. (Show Details)Jun 30 2016, 3:43 PM
dr0ptp4kt lowered the priority of this task from High to Medium.Jul 1 2016, 5:50 PM
MBinder_WMF moved this task from 2016-17 Q2 to 2015-16 Q4 on the Web-Team-Backlog-Archived board.Jul 5 2016, 4:42 PM
Jdlrobson claimed this task.Jul 6 2016, 7:51 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-76-Retrosprekfast board.
gerritbot subscribed.Jul 6 2016, 7:57 PM

Change 297636 had a related patch set uploaded (by Jdlrobson):
Avoid 1px jump when focus search

https://gerrit.wikimedia.org/r/297636

gerritbot added a project: Patch-For-Review.Jul 6 2016, 7:57 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 6 2016, 7:59 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 7 2016, 3:25 AM
Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 7 2016, 5:27 PM
MBinder_WMF moved this task from 2015-16 Q4 to 2016-17 Q1 on the Web-Team-Backlog-Archived board.Jul 7 2016, 8:11 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 7 2016, 11:50 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 8 2016, 12:28 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 8 2016, 7:39 PM
• Jhernandez moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 11 2016, 11:27 AM
Jdlrobson added a comment.Jul 11 2016, 5:02 PM

The -1 from Jenkins is unrelated to my patch.

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 11 2016, 5:02 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 11 2016, 11:49 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 12 2016, 12:17 AM
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 12 2016, 5:13 AM
gerritbot added a comment.Jul 12 2016, 5:20 AM

Change 297636 merged by jenkins-bot:
Avoid 1px jump when focus search

https://gerrit.wikimedia.org/r/297636

• bmansurov closed this task as Resolved.Jul 12 2016, 5:45 AM

To test please visit http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page

I tested the fix using:

  • Firefox 47.0, Chrome 51.0.2704.84, Safari 9.1.1 on Mac OS X 10.11.5.
  • IE 11 on Windows 7, Edge 14 on Windows 10
  • Nokia Lumia 930 on Windows Phone 8.1
  • Chrome on Android 4.4 on Nexus 5
  • Chrome on Android 5.0 on Nexus 6
  • Chrome on Android 6.0 on Nexus 6
  • Safari on IOS 9.0 on iPhone 6S Plus
  • Opera Mini beta 17.0.2211.105077 on Android 6, Nexus 5X.

Feel free to test on other suggested devices

• bmansurov removed a project: Patch-For-Review.Jul 12 2016, 5:48 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 12 2016, 6:00 AM
Jdlrobson reopened this task as Open.Jul 13 2016, 3:33 PM

This has caused an issue with VisualEditor. Signed off a little hastily.

• bmansurov added a comment.Jul 13 2016, 3:52 PM

Can you share a link to the issue?

Jdlrobson added a comment.Jul 13 2016, 4:11 PM

No bug was raised but see https://gerrit.wikimedia.org/r/#/c/298773/1
With the Nokia issue you raised as well, let's thus spending a little longer verifying.

Jdlrobson added a comment.Jul 13 2016, 5:11 PM

(This has probably caused T140051)

Jdlrobson added a subtask: T140051: Search overlay clear icon is misplaced on Nokia Lumia 930 / Windows Phone 8.1.Jul 13 2016, 8:45 PM
Jdlrobson mentioned this in T140051: Search overlay clear icon is misplaced on Nokia Lumia 930 / Windows Phone 8.1.
dr0ptp4kt closed subtask T140051: Search overlay clear icon is misplaced on Nokia Lumia 930 / Windows Phone 8.1 as Resolved.Jul 15 2016, 5:58 PM
dr0ptp4kt closed this task as Resolved.Jul 16 2016, 2:28 AM
dr0ptp4kt subscribed.

This seemed okay in the UAs where I checked:

Mac OS X: latest Chrome, Firefox, Safari stable
iPhone 5c iOS 9.3 Safari
LG Nexus 4 Android 5 Chrome
LG Nexus 4 Android 5 Opera Mini non-compressed mode (supports RL)
LG Nexus 4 Android 5 UC browser (not mini)
Nexus 7 Android 5 Chrome

Windows Phone 7.5 stuff is noted in T140504: Windows Phone 7.5 Search UX Issues. I'm considering it out of scope here.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits