Pywikibot does not mark item merges as bot
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Jun 21 2016, 11:47 AM

Description

pywikibot.ItemPage.mergeInto() calls pywikibot.DataSite.mergeItems() which does not allow marking this edit as done by bot (see also T87103).

Details

	Subject	Repo	Branch	Lines +/-
	pywikibot.DataSite.mergeItems must set the bot flag	pywikibot/core	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: T87103: wbcreateredirect should act upon the 'bot' param
Mentioned Here: T87103: wbcreateredirect should act upon the 'bot' param

Event Timeline

matej_suchanek created this task.Jun 21 2016, 11:47 AM

Restricted Application added subscribers: pywikibot-bugs-list, Zppix, TerraCodes, Aklapper. · View Herald TranscriptJun 21 2016, 11:47 AM

matej_suchanek mentioned this in T87103: wbcreateredirect should act upon the 'bot' param.Jun 21 2016, 11:53 AM

The mergeInto allows bot=True since it pass all kwargs to mergeItems regardless.

def mergeInto(self, item, **kwargs):
    """
    Merge the item into another item.

    @param item: The item to merge into
    @type item: pywikibot.ItemPage
    """
    self.repo.mergeItems(fromItem=self, toItem=item, **kwargs)

Change 301776 had a related patch set uploaded (by Dachary):
pywikibot.DataSite.mergeItems must set the bot flag

https://gerrit.wikimedia.org/r/301776

Maybe pywikibot.ItemPage.mergeInto should also have an explicit bot=True argument so that the default is to set the bot flag ?

matej_suchanek added a project: Patch-For-Review.Jul 29 2016, 12:40 PM

Change 301776 merged by jenkins-bot:
pywikibot.DataSite.mergeItems must set the bot flag