We left the Auth classes in a bit of a mess.
Until we are able to get to T132700, we just need to clean up the classes a bit mostly by removing the old auth logic and getting rid of some of the copy pasted code
Description
Description
Related Objects
Related Objects
- Mentioned In
- rAPIOS58ce548903a0: Merge pull request #737 from wikimedia/feature/T138350/login-cleanup
rAPIOSa6a82c2d2eef: Merge branch 'develop' into feature/T138350/login-cleanup
rAPIOS04e2ce18c358: Merge branch 'develop' into feature/T138350/login-cleanup - Mentioned Here
- T132700: Refactor and DRY login logic and modernize to use new fetcher logic
Event Timeline
Comment Actions
To test:
- Perform a login with a known user and confirm success
- Perform an account create with a new user and confirm success
- Perform a logout and confirm success
Comment Actions
Testing on iPhone with iOS 9.3.2 and Wikipedia app 5.0.5 (885), this is fixed as it is possible to create a new account, login with a known user, and logout for both. (note: this is fixed on the beta app only, it's still an issue with the version in the App store)