Regression with gifs not making it to the cache. Makes them not appear in gallery.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Jun 21 2016, 11:02 PM

Description

Noticed it when tapping the animated gif on "enwiki > tangent".

Tap on that image and you see the first image in the gallery instead of the animated gif.

set a breakpoint inside "- (BOOL)isLargeEnoughForGalleryInclusion" after the "imageFromAppImageCache" line.
load the "enwiki > tangent"
tap the animated gif
the breakpoint should trip, and you can see the image returned by "imageFromAppImageCache" is nil

Related Objects

Mentioned In: rAPIOSadc607dfd489: Merge pull request #731 from wikimedia/T138358/image_caching
Mentioned Here: T139092: Images that are not part of core article content are being included in image gallery list

Event Timeline

Mhurd created this task.Jun 21 2016, 11:02 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 21 2016, 11:02 PM

Just confirmed this is not a regression from the app store release, sorry. I remember testing with this image... perhaps it regressed in a recent release?

https://github.com/wikimedia/wikipedia-ios/pull/731

• Fjalapeno mentioned this in rAPIOSadc607dfd489: Merge pull request #731 from wikimedia/T138358/image_caching.Jun 22 2016, 9:32 PM

• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jun 22 2016, 9:32 PM

To test:

Open the "tangent" article
Scroll down until you see the animated gif
Tap on the animated gif
Verify the gallery opens showing the animated gif

• Fjalapeno moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.1.0-Saturn board.Jun 22 2016, 9:53 PM

Testing on Wikipedia app 5.0.5 (884) on iOS 9.3.2 iPhone. This is fixed as the gif continues to animate when opened in the image gallery.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Jun 22 2016, 11:45 PM

• JMinor raised the priority of this task from Medium to High.Jun 27 2016, 9:16 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Potentially related to T139092?

• JMinor lowered the priority of this task from High to Medium.Jun 30 2016, 6:35 PM

• JMinor edited projects, added iOS-app-v5.0.5-Fever; removed iOS-app-v5.1.0-Saturn.

• JMinor moved this task from Tasks from Product Backlog to Ready for PM Signoff on the iOS-app-v5.0.5-Fever board.Jun 30 2016, 6:38 PM

Danny_B added a project: Regression.Jul 1 2016, 9:00 PM

Verified gifs in tanget are in gallery in 5.0.5 893

• JMinor closed this task as Resolved.Jul 7 2016, 6:49 PM

Regression with gifs not making it to the cache. Makes them not appear in gallery.Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Regression with gifs not making it to the cache. Makes them not appear in gallery.
Closed, ResolvedPublic
Actions