Page MenuHomePhabricator
Create Task
Maniphest T138430

Hovercards do not show thumbnails in Safari browser
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

If you have Hovercards enabled and are using Safari on a Mac, you do not see the images in the pop up.

Steps to reproduce.

  • Find a Mac and open Safari :)
  • Login to any Wikimedia wiki with Hovercards available as a beta feature
  • Enable Hovercards
  • Visit an article with an internal link to a page with a freely licensed photo
  • Hover over that link
  • See something like this:
    Screen Shot 2016-06-22 at 12.32.59 PM.png (454×392 px, 57 KB)

Software versions:

  • Mac OS X 10.11.5 (El Capitan)
  • Safari 9.1.1

This was reported by a community member at: https://www.mediawiki.org/w/index.php?title=Topic:T6d7r5op34wrm7gx

See also: T64985

Details

SubjectRepoBranchLines +/-
Workaround for display of SVG images in Safarimediawiki/extensions/Popupsmaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

CKoerner_WMF created this task.Jun 22 2016, 5:43 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 22 2016, 5:43 PM
TheDJ added a project: Browser-Support-Apple-Safari.Jun 23 2016, 1:10 PM
• bmansurov added a project: Web-Team-Backlog.Jun 23 2016, 5:00 PM
Jdlrobson removed a project: Web-Team-Backlog.Jun 23 2016, 5:09 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jun 23 2016, 5:14 PM
Jdlrobson subscribed.

SVG related?

Jdlrobson triaged this task as High priority.Jun 23 2016, 5:14 PM
• jhobs added subscribers: dr0ptp4kt, • jhobs.Jun 23 2016, 5:15 PM

@dr0ptp4kt this was almost UBN. Would be good if you could prioritize this very highly.

dr0ptp4kt added projects: Unplanned-Sprint-Work, Reading-Web-Sprint-75-Quantitative-Paralysis.Jun 23 2016, 5:33 PM

Yikes. Let's fix this the right way, and let's do so in the current sprint. I'm updating the tags and will move it in the sprint and backlog boards.

dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 23 2016, 5:34 PM
• jhobs claimed this task.Jun 26 2016, 9:49 AM
• jhobs moved this task from To Do to Doing on the Reading-Web-Sprint-75-Quantitative-Paralysis board.
Jdlrobson added a comment.Jun 27 2016, 6:34 PM

I can replicate on Version 9.1.1 (11601.6.17) of Safari on OSX

• jhobs removed • jhobs as the assignee of this task.Jun 27 2016, 7:30 PM

Throwing this up for grabs while I'm working on the UBN.

• jhobs moved this task from Doing to To Do on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 7:31 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 8:07 PM
gerritbot subscribed.Jun 27 2016, 8:44 PM

Change 296278 had a related patch set uploaded (by Jdlrobson):
Workaround for display of SVG images in Safari

https://gerrit.wikimedia.org/r/296278

gerritbot added a project: Patch-For-Review.Jun 27 2016, 8:44 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 8:45 PM

Not proud of fix, can't work out why it's a problem, but it does the job. If anyone wants to investigate more feel free..

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 28 2016, 9:48 AM
phuedx moved this task from Ready for Signoff to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.
phuedx subscribed.

^ I've had a little too much coffee today ☕️

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 28 2016, 10:17 AM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 28 2016, 4:50 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 29 2016, 8:44 AM
• Jhernandez moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 29 2016, 4:01 PM
MBinder_WMF moved this task from Triaged but Future to 2015-16 Q4 on the Web-Team-Backlog board.Jun 29 2016, 5:17 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 29 2016, 6:50 PM
gerritbot added a comment.Jun 29 2016, 6:52 PM

Change 296278 merged by jenkins-bot:
Workaround for display of SVG images in Safari

https://gerrit.wikimedia.org/r/296278

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jun 29 2016, 7:00 PM
Jdlrobson closed this task as Resolved.Jun 29 2016, 11:09 PM
Jdlrobson claimed this task.
• Jhernandez set the point value for this task to 1.Jun 30 2016, 8:54 AM
Jdlrobson changed the point value for this task from 1 to 2.Jun 30 2016, 3:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL