Page MenuHomePhabricator

MWSyntaxHighlightDialog: Set `autocomplete: 'live'` in MWAceEditorWidget to provide autocompletion like in MWMathDialog
Closed, ResolvedPublic1 Story Points

Description

The Code Blocks ( insert->code blocks) section only supports the text highlighting(I guess its GeSHi). The autocompletion and snippets of the language inputted are not enabled. May be the call to the CodeEditor (Ace)are not done properly or the languages and respective mode are not set properly.

The CodeEditor seperately is working fine ,if we take the case of the insert math formula where the autocompletion is working fine.
The math formula , although uses an instance defined by the visual editor ( modules->ve-mw->ui->widgets->ve.ui.MWAceEditor.js) .

It was not clear to me where the codeblock calls the instance of the ace editor are made.

Feedback discussion :
https://www.mediawiki.org/wiki/Topic:T5x13al94xj3r6sa

Details

Related Gerrit Patches:
mediawiki/extensions/SyntaxHighlight_GeSHi : masterEnable live autocomplete

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 23 2016, 3:29 AM
Jdforrester-WMF renamed this task from AutoCompletion and Snippets not working in Code Blocks to MWSyntaxHighlightDialog: Set `autocomplete: 'live'` in MWAceEditorWidget to provide autocompletion like in MWMathDialog.Jun 23 2016, 8:39 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added subscribers: Tchanders, Esanders.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

It looks like it's a one line change… is there a reason we didn't do it beforehand?

Change 311451 had a related patch set uploaded (by DLynch):
Enable live autocomplete

https://gerrit.wikimedia.org/r/311451

Change 311451 merged by jenkins-bot:
Enable live autocomplete

https://gerrit.wikimedia.org/r/311451

Jdforrester-WMF closed this task as Resolved.Sep 20 2016, 9:57 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF removed a project: Patch-For-Review.