With a null edit on http://en.wikisource.beta.wmflabs.org/wiki/Page:Dictionary_of_National_Biography_volume_51.djvu/358?veaction=edit :
I get a different dirty diff with the same code locally:
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Removes <div class="pagetext"> during VisualEditor loading | mediawiki/extensions/ProofreadPage | master | +16 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T52000 Enable VisualEditor by default for all users of all Wikimedia wikis | |||
| Open | None | T138391 Enable VisualEditor by default for all users of all Wikisources | |||
| Open | None | T138966 Make the VisualEditor/ProofreadPage integration good enough to enable by default | |||
| Resolved | Tpt | T138472 ProofreadPageTarget dirty diffing |
Event Timeline
Comment Actions
Looking at the HTML:
Before:
<body> <meta typeof="mw:Includes/NoInclude" id="mwAQ"> <div [mw template]></div> <div class="pagetext" id="mwAw"> <span [mw template]></span> <p id="mwBQ"> <br id="mwBg"/> <meta typeof="mw:Includes/NoInclude/End" id="mwBw"> Foo bar baz </p> <p id="mwCQ"> Quux </p> <meta typeof="mw:Includes/NoInclude" id="mwEg"> <ol class="mw-references" typeof="mw:Extension/references"></ol> </div> <meta typeof="mw:Includes/NoInclude/End" id="mwFA"> </body>
<body> <meta typeof="mw:Includes/NoInclude" id="mwAQ"> <div [mw template]></div> <div class="pagetext" id="mwAw"> <span [mw template]></span> <p id="mwBQ"><br id="mwBg"></p> </div> <meta typeof="mw:Includes/NoInclude/End" id="mwBw"> Foo bar baz <p id="mwCQ"> Quux </p> <meta typeof="mw:Includes/NoInclude" id="mwEg"> <ol class="mw-references" typeof="mw:Extension/references"></ol> <meta typeof="mw:Includes/NoInclude/End" id="mwFA"> </body>
The paragraph gets unwrapped but converting this to wikitext that shouldn't be a problem.
Comment Actions
Because the <div class="pagetext"> is being confined to the header so sections are balanced, which means closing it when the mwBw noinclude is encountered.
Comment Actions
Sorry, I meant <meta typeof="mw:Includes/NoInclude/End" id="mwBw"> being moved out of <p id="mwBQ"><br id="mwBg"></p> (along with the text node).
Comment Actions
So part of the problem is that <div class="pagetext"> is cached by RESTBase, so we'll need to do a big purge now the content model has changed.
Comment Actions
The pagetext div was a caching issue, we got it to go away by editing the page. The remaining dirty diff happened because {{RunningHeader}}</noinclude>at a later date.) blah blah blah was all considered one template by Parsoid, and we tried to split in the middle of a templated block. This is now "fixed" because I imported the RunningHeader template (it was previously a red link).
This fixed the dirty diff (see this clean VE edit), but the first paragraph was still considered templated in its entirety. I "fixed" this by removing newlines from the float left template, but this seems to be another Parsoid bug. I'll try to isolate these bugs.
Comment Actions
Change 297138 had a related patch set uploaded (by Tpt):
Removes <div class="pagetext"> during VisualEditor loading
Comment Actions
Change 297138 merged by jenkins-bot:
Removes <div class="pagetext"> during VisualEditor loading