Page MenuHomePhabricator
Create Task
Maniphest T138529

Notice: Undefined index: in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Since rolling forward wmf.7 there are a lot of undefined index notices for abusefilter:

Notice: Undefined index: 279 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754
Notice: Undefined index: 67 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754
Notice: Undefined index: 17 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754
Notice: Undefined index: 122 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	5 	
Notice: Undefined index: 122 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 1731 	5 	
Notice: Undefined index: 80 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	4 	
Notice: Undefined index: 686 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	4 	
Notice: Undefined index: 686 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 1731 	4 	
Notice: Undefined index: 112 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	4 	
Notice: Undefined index: 1 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 826 	4 	
Notice: Undefined index: 1 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	4 	
Notice: Undefined index: 1 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 1731 	4 	
Notice: Undefined index: 84 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	3 	
Notice: Undefined index: 82 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 826 	3 	
Notice: Undefined index: 82 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	3 	
Notice: Undefined index: 82 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 1731 	3 	
Notice: Undefined index: 8 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 754 	3 	
Notice: Undefined index: 8 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 1731 	3 	
Notice: Undefined index: 37 in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php on line 826

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix $filters and $tagsToSet static variable handlingmediawiki/extensions/AbuseFilterwmf/1.28.0-wmf.8+84 -28
Fix $filters and $tagsToSet static variable handlingmediawiki/extensions/AbuseFiltermaster+84 -28
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Jun 23 2016, 7:54 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 23 2016, 7:54 PM
greg triaged this task as High priority.Jun 23 2016, 8:02 PM
greg mentioned this in T138550: 1.28.0-wmf.7 save time regression.Jun 24 2016, 3:02 AM
aaron claimed this task.Jun 28 2016, 10:47 PM
aaron merged a task: T138528: Notice: Cannot access property on non-object in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php.Jun 28 2016, 10:57 PM
gerritbot subscribed.Jun 29 2016, 12:07 AM

Change 296491 had a related patch set uploaded (by Aaron Schulz):
Fix $filters and $tagsToSet static variable handling

https://gerrit.wikimedia.org/r/296491

gerritbot added a project: Patch-For-Review.Jun 29 2016, 12:07 AM
gerritbot added a comment.Jun 30 2016, 12:56 AM

Change 296491 merged by jenkins-bot:
Fix $filters and $tagsToSet static variable handling

https://gerrit.wikimedia.org/r/296491

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jun 30 2016, 1:00 AM
Krinkle closed this task as Resolved.Jun 30 2016, 4:37 PM
gerritbot added a comment.Jun 30 2016, 8:46 PM

Change 296827 had a related patch set uploaded (by 20after4):
Fix $filters and $tagsToSet static variable handling

https://gerrit.wikimedia.org/r/296827

hashar mentioned this in T139113: Cannot access property on non-object in /srv/mediawiki/php-1.28.0-wmf.8/extensions/AbuseFilter/AbuseFilter.class.php on line 754.Jul 13 2016, 8:41 AM
hashar merged a task: T139113: Cannot access property on non-object in /srv/mediawiki/php-1.28.0-wmf.8/extensions/AbuseFilter/AbuseFilter.class.php on line 754.
hashar added subscribers: hashar, ori, aaron, • mmodell.
gerritbot added a comment.Jul 15 2016, 9:29 PM

Change 296827 abandoned by Bartosz Dziewoński:
Fix $filters and $tagsToSet static variable handling

Reason:
wmf.8 is no longer live.

https://gerrit.wikimedia.org/r/296827

matmarex mentioned this in T139657: Fatal error: Invalid static property access: AbuseFilter::filters in AbuseFilterCheck.php on line 121.Jul 15 2016, 9:31 PM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:46 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits