Page MenuHomePhabricator

Convert Savebutton from UIControl to UIButton to get accessibility features
Closed, ResolvedPublic

Description

Currently this button is invisible to accessibility because its not actually a button.

We should inherit from UIButton unless it is impossible to do so.

In that case, we should implement the accessibility methods needed

Event Timeline

JMinor triaged this task as Medium priority.Jun 27 2016, 9:50 PM
JMinor subscribed.

I'm going to put this into scope for Saturn, since it seems like this is a change we can make now in isolation, not dependent on feed changes, etc.

Related issue mentioned by Austin in his audit:
"The “Save” button on an article does not indicate its selected state. For this use UIAccessibilityTraitSelected."

Note that this was fixed by implementing the accessibility methods, not by converting to a UIButton