Page MenuHomePhabricator

Backend naming in VCL needs to use fqdn+port
Closed, DeclinedPublic

Description

We've run into this twice now. Existing proposed faulty patch here: https://gerrit.wikimedia.org/r/#/c/276529

The problem is that the backend name (not hostname, but labelling key) in VCL is built from only the first label of the actual backend hostname (or all of the digits of the IP, if it's an IPv4 address). This should include at least the next label (for datacenter name), if not the whole fqdn. It should also include the port number. The complication is that we have to do this transformation in two places identically: once in puppet/ruby, and once in a go template, and the go template lacks regex functionality.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

Change 276529 had a related patch set uploaded (by Ema):
common VCL: use FQDN for backend naming

https://gerrit.wikimedia.org/r/276529

Change 276529 merged by Ema:
common VCL: use FQDN for backend naming

https://gerrit.wikimedia.org/r/276529

Mentioned in SAL [2016-08-16T12:13:11Z] <ema> re-enabling puppet on cache hosts (T138546)

Change 305020 had a related patch set uploaded (by Gehel):
WDQS - fix icinga graphite check, metric has been renamed

https://gerrit.wikimedia.org/r/305020

Change 305020 merged by Gehel:
WDQS - fix icinga graphite check, metric has been renamed

https://gerrit.wikimedia.org/r/305020

Change 306582 had a related patch set uploaded (by BryanDavis):
Add service name californium8044 for californium.wikimedia.org

https://gerrit.wikimedia.org/r/306582

Change 306582 abandoned by BryanDavis:
Add service name californium8044 for californium.wikimedia.org

Reason:
This is gross. We'll fix it another way.

https://gerrit.wikimedia.org/r/306582

Varnish backends are gone since T227432, this is now unnecessary.