Page MenuHomePhabricator

Title is ignored when curid is passed (RecentChanges hist link does not work)
Closed, ResolvedPublic

Description

Problem

Visiting any URL with curid, the curid seems to trump the title
e.g. https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&curid=34406167

In mobile, given the history page is a special page this creates problems, as the URL
https://en.wikipedia.org/w/index.php?title=Special:History/Johnny_Guitar_(song)&curid=34406167 doesn't do what's expected (behave like https://en.wikipedia.org/w/index.php?title=Johnny_Guitar_(song)&curid=37271490&action=history)

Original report

Visit Special:RecentChanges on the mobile website and click any of the "history" link of one of the articles. The link will take you to the history URL of the current version (e.g. https://ro.m.wikipedia.org/w/index.php?title=Special:History/Timi%C8%99oara&curid=5524) instead of the URL of the history pages (https://ro.m.wikipedia.org/wiki/Special:History/Timi%C8%99oara).

The users expect from the desktop site that the link called "History" takes them to the history page, not an ancient version of the page/

Developer notes

The addition of curid seems to override the title. Why?

https://en.m.wikipedia.org/w/index.php?title=Special:History/Johnny_Guitar_(song)&curid=34406167

Event Timeline

Jdlrobson renamed this task from History link in mobile RecentChanges takes you to the current version instead of the history page to Title is ignored when curid is passed.Jul 25 2017, 5:59 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.
matmarex subscribed.

curid indeed overrides title, that's expected. I don't know if there is a specific reason for it, but it has always been that way and it's documented e.g. at https://www.mediawiki.org/wiki/Manual:Parameters_to_index.php#Page_revision_or_version. MobileFrontend seems to be generating the links wrong.

Jdlrobson renamed this task from Title is ignored when curid is passed to Title is ignored when curid is passed (RecentChanges hist link does not work).Jul 25 2017, 6:03 PM
Jdlrobson added subscribers: aude, StudiesWorld.
matmarex renamed this task from Title is ignored when curid is passed (RecentChanges hist link does not work) to Title is ignored when curid is passed.Jul 25 2017, 6:03 PM
matmarex renamed this task from Title is ignored when curid is passed to Title is ignored when curid is passed (RecentChanges hist link does not work).
matmarex removed a project: MediaWiki-General.
matmarex updated the task description. (Show Details)
matmarex unsubscribed.

Change 499864 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the SpecialMobile(History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

Change 499864 abandoned by Jdlrobson:
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

Change 501449 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop History override on mobile

https://gerrit.wikimedia.org/r/501449

Change 501449 abandoned by Jdlrobson:
Drop History override on mobile

Reason:
Not enough resources/focus to work on this right now.

https://gerrit.wikimedia.org/r/501449