When switching from WikiEditor editor to VisualEditor only the content of wpTextbox1 is retrieved and not all the fields (wpHeaderTextbox, wpTextbox1, wpFooterTextbox and wpQuality)
ProofreadPage should be able to override ArticleTargetLoader.requestPageData in order to retrieve content from all fields
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Rebuild full wikitext when switching from WTE to VE | mediawiki/extensions/ProofreadPage | master | +22 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T52000 Enable VisualEditor by default for all users of all Wikimedia wikis | |||
| Open | None | T138391 Enable VisualEditor by default for all users of all Wikisources | |||
| Open | None | T138966 Make the VisualEditor/ProofreadPage integration good enough to enable by default | |||
| Resolved | Tpt | T138673 VisualEditor should retrieve content of all Page: pages wikitext editor field when switching from WikiEditor |
Yes, but at this stage ve.init.mw isn't even set up so we can't go and get a function in the appropriate target to ask it for wikitext to send.
How does this cause issues in regular articles?
@Jdforrester-WMF Does someone in your team plans to work on it soon or is an external change proposal welcome? As the loading of the Wikitext edit form content is not part of the ArticleTarget interface yet, this change is probably going to be a bit tricky.
I've been thinking about this today, and recently moved from using .val() to .textSelection( 'getContents' ) in VE for another piece of editing software to help with switching in a similar case (WTE->VE) - T135747. Maybe what we could do is have a hidden input element that's just used by JS to store a jquery.textSelection-style function.
ProofreadPage could register a getWikitext handler (which would get stored in the input element's data, and would know how to build the full wikitext from wpHeaderTextbox, wpFooterTextbox, and wpQuality as well as wpTextbox1), overriding the default of something like this.parent( 'form' ).find( '#wpTextbox1' ).textSelection( 'getContents' ). VE would call it when appropriate (replacing all our current textSelection calls), and magically get back the full wikitext to submit to RB.
@Esanders, @Krinkle: Any thoughts/objections?
Storing a function in data seems a bit strange, but I @Krinkle will have a better idea of how the get wikitext stuff should work.
Lowering priority to actually reflect reality ("Unbreak Now!" priority for nearly half a year and no assignee set by the VisualEditor team).
Change 331642 had a related patch set uploaded (by Esanders):
Rebuild full wikitext when switching from WTE to VE
Change 331642 merged by jenkins-bot:
Rebuild full wikitext when switching from WTE to VE