Whitespace inside HTML comments in transclusion parameters are lost on editing(?)
Open, NormalPublic8 Story Points

Description

Sample diff

Expected behavior: the comment should stay unmodified

Actual behavior: blank lines have been removed

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 25 2016, 8:38 PM

I am not sure this is necessarily a Parsoid issue. I think VE might have dropped the comment during the edit of the parameter or could have been an editor issue where the editor might have unintentionally deleted the comment while updating the parameter.

Right now, Parsoid considers that comment as part of the template parameter and encodes it as such. So, this could be considered a Parsoid issue if the current representation of the comment is considered inadequate for preserving them. I am not convinced that we need to change the representation since I can imagine those changes replacing this "edge case" with other edge cases.

So, I am inclined to classify this as a VE / user-error rather than a Parsoid issue.

ssastry renamed this task from HTML comments blank lines are slurped by Parsoid to HTML comments and blank lines in an edited transclusion are lost during the edit.Jun 27 2016, 4:08 PM
Jdforrester-WMF renamed this task from HTML comments and blank lines in an edited transclusion are lost during the edit to Whitespace inside HTML comments in transclusion parameters are lost on editing(?).Aug 9 2016, 7:13 PM
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.