Page MenuHomePhabricator

Determine source of notifications API change
Closed, ResolvedPublic

Description

Sometime in the past two years, the JSON returned from api.php?action=query&meta=notifications started including a list under query.notifications.list instead of a dictionary keyed on notification IDs.

I was wondering what change to the notifications code resulted in this API change as I was patching Pywikibot to recognize the new format.

Event Timeline

Enterprisey claimed this task.

Yep, that's right.

I'm sorry, we should have announced this change on the mediawiki-api-announce mailing list. Apologies for not doing so.

Is the change starting from a specific MW release (e.g. < MW 1.2x as dict, >= MW1.2x as list)?

@Catrope Is someone going to do the right thing and announce it, even if it's 3 months late? Better late than never ^^

The change has been done on an extension, though, not in core, so the MediaWiki version may be a bit fuzzy, although extensions are usually tagged with a MediaWiki release whenever a new MediaWiki release is created (well... almost... T66157)

@Catrope Is someone going to do the right thing and announce it, even if it's 3 months late? Better late than never ^^

Sure, I'll do that tomorrow.

Change 295567 had a related patch set uploaded (by Mpaa):
Fix notifications query parse

https://gerrit.wikimedia.org/r/295567

Change 295567 merged by jenkins-bot:
Fix notifications query parse

https://gerrit.wikimedia.org/r/295567