Page MenuHomePhabricator
Create Task
Maniphest T138765

Cosmetic changes breaks tables
Open, HighPublic
Actions

Description

Please see this edit. Bot moves categories to the bottom of a page, but it also removes newline after and therefore breaks table.

Configuration
last commit of pwb core from Gerrit, Python v3.5.2

Details

ProjectBranchLines +/-Subject
pywikibot/coremaster+12 -12[bugfix] Do not remove spaces after categories and language links
pywikibot/coremaster+13 -13[bugfix] Do not remove spaces around categories and language links
Customize query in gerrit

Related Objects

Event Timeline

Dvorapa created this task.Jun 27 2016, 3:43 PM
Restricted Application added subscribers: pywikibot-bugs-list, Zppix, Aklapper. · View Herald TranscriptJun 27 2016, 3:44 PM
Danny_B added a subscriber: Danny_B.Jun 29 2016, 11:30 AM
Dvorapa updated the task description. (Show Details)Jul 14 2016, 11:29 AM
Dvorapa updated the task description. (Show Details)
Dvorapa mentioned this in T63024: cosmetic changes must not remove useless spaces inside templates.Jul 18 2016, 8:41 PM
Xqt added a subscriber: Xqt.Jul 25 2016, 3:46 AM

Some samples would be great.

Dvorapa added a comment.Jul 25 2016, 5:13 PM

@Xqt One is in the description

Xqt added a comment.Jul 27 2016, 4:10 AM

Ah yes. I've overseen that. cc removes additional line break when moving categories and the closing bracket of the table fails.

Xqt triaged this task as High priority.Jul 27 2016, 4:11 AM
Dvorapa added a project: Pywikibot.Jan 10 2017, 8:51 PM
Dvorapa updated the task description. (Show Details)May 28 2017, 8:49 AM
Dvorapa added a project: good first task.May 20 2018, 2:51 PM
Dvorapa removed a project: good first task.May 20 2018, 10:11 PM
Dvorapa added a project: good first task.Jun 4 2018, 4:36 AM
Dvorapa added a comment.Nov 15 2018, 2:51 PM

Still valid: https://cs.wikipedia.org/w/index.php?title=Wikipedista:Oasis98&diff=prev&oldid=16161207&diffmode=source

Restricted Application added a subscriber: Urbanecm. · View Herald TranscriptNov 15 2018, 2:51 PM
gerritbot added a subscriber: gerritbot.Nov 18 2018, 8:55 PM

Change 474552 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Do not remove spaces around categories

https://gerrit.wikimedia.org/r/474552

gerritbot added a project: Patch-For-Review.Nov 18 2018, 8:55 PM
Mahveotm moved this task from Backlog to Needs Review on the Pywikibot board.Jan 22 2019, 10:07 AM
Xqt assigned this task to Dvorapa.Jan 25 2019, 5:03 AM
gerritbot added a comment.May 31 2019, 11:39 AM

Change 474552 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Do not remove spaces around categories

https://gerrit.wikimedia.org/r/474552

Dvorapa updated the task description. (Show Details)May 31 2019, 12:17 PM
gerritbot added a comment.May 31 2019, 3:18 PM

Change 513622 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Do not remove spaces around categories and language links

https://gerrit.wikimedia.org/r/513622

Dvorapa removed Dvorapa as the assignee of this task.Mar 27 2020, 4:36 PM

Not actively working on it

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 26 2022, 7:41 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL