TMH video.js-mode iframe embedding code runs on every page view, removing element with id 'bgimage'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• brooke
	Jun 27 2016, 4:41 PM

Project Tags

Referenced Files

None

Subscribers

Description

Followup from https://gerrit.wikimedia.org/r/#/c/296156/ -- iframe embedding code for video.js gets run on every page view, causing any element with id 'bgimage' to be removed.

This code should only be run on the iframe embed view, and nowhere else.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Remove last trace of bgimage	TheDJ	mediawiki/extensions/TimedMediaHandler	master	+0 -4

Customize query in gerrit

Event Timeline

• brooke created this task.Jun 27 2016, 4:41 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 27 2016, 4:41 PM

TheDJ moved this task from Backlog to Video.js on the Kaltura player board.Oct 14 2016, 7:09 PM

TheDJ added a project: TimedMediaHandler.Jan 16 2017, 5:21 AM

TheDJ moved this task from To sort to Doing on the TimedMediaHandler board.

Change 332204 had a related patch set uploaded (by TheDJ):
Remove last trace of bgimage

https://gerrit.wikimedia.org/r/332204

gerritbot added a project: Patch-For-Review.Jan 16 2017, 5:30 AM

Jdforrester-WMF closed this task as Resolved.Jan 16 2017, 7:44 PM

Jdforrester-WMF assigned this task to TheDJ.

Jdforrester-WMF edited projects, added: Performance Issue; removed: Patch-For-Review.

Change 332204 merged by jenkins-bot:
Remove last trace of bgimage

https://gerrit.wikimedia.org/r/332204

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 16 2017, 8:00 PM

Aklapper removed a project: TimedMediaHandler.Nov 7 2019, 4:02 PM

TMH video.js-mode iframe embedding code runs on every page view, removing element with id 'bgimage'Closed, ResolvedPublicActions

Description

Details

Event Timeline

TMH video.js-mode iframe embedding code runs on every page view, removing element with id 'bgimage'
Closed, ResolvedPublic
Actions