Page MenuHomePhabricator

Cannot read property 'split' of undefined on ?embedplayer=yes
Closed, DuplicatePublic

Description

On https://commons.wikimedia.org/wiki/File:New_medical_editor.ogv?embedplayer=yes

TypeError: Cannot read property 'split' of undefined
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 Object.getMIMETypePlayers (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 Object.defaultPlayer (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 Object.isPlayableType (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 Object.getPlayableSources (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 Object.autoSelectSource (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 HTMLDivElement.setupSourcePlayer (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 eval (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 doCallbackCheck (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 HTMLDivElement.eval (eval at ()
 /w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:4:681 Object.eval (eval at ()

On https://commons.wikimedia.org/wiki/File:New_medical_editor.ogv?debug=true&embedplayer=yes

TypeError: Cannot read property 'split' of undefined
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayers.js?00803:95:30 Object.getMIMETypePlayers()
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayers.js?00803:118:26 Object.defaultPlayer()
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js?ca54f:430:40 Object.isPlayableType()
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js?ca54f:476:15 Object.getPlayableSources()
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js?ca54f:165:30 Object.autoSelectSource()
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js?adda9:685:22 HTMLDivElement.setupSourcePlayer()
 /w/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js?adda9:612:11
 /w/load.php?debug=true&lang=en&modules=Spinner%7Cext.tmh.embedPlayerIframe%7Cjquery.loadingSpinner%2CmwEmbedUtil%2CtriggerQueueCallback%7Cmw.MwEmbedSupport%7Cmw.MwEmbedSupport.style&skin=vector&version=2ae5dca68f52:185:5 doCallbackCheck()
 /w/extensions/TimedMediaHandler/resources/mw.MediaWikiPlayerSupport.js?89fbf:328:5 HTMLDivElement.()
 /w/load.php?debug=true&lang=en&modules=Spinner%7Cext.tmh.embedPlayerIframe%7Cjquery.loadingSpinner%2CmwEmbedUtil%2CtriggerQueueCallback%7Cmw.MwEmbedSupport%7Cmw.MwEmbedSupport.style&skin=vector&version=2ae5dca68f52:193:28 Object.()
getMIMETypePlayers		@	mw.MediaPlayers.js?00803:95
defaultPlayer			@	mw.MediaPlayers.js?00803:118
isPlayableType			@	mw.MediaElement.js?ca54f:430
getPlayableSources		@	mw.MediaElement.js?ca54f:476
autoSelectSource		@	mw.MediaElement.js?ca54f:165
setupSourcePlayer		@	mw.EmbedPlayer.js?adda9:685
(anonymous function)		@	mw.EmbedPlayer.js?adda9:612
doCallbackCheck			@	load.php?debug=true&lang=en&modules=Spinner|ext.tmh.embedPlayerIframe|jquery.loadingSpinner%2CmwEmb…:185
(anonymous function)		@	mw.MediaWikiPlayerSupport.js?89fbf:328
(anonymous function)		@	load.php?debug=true&lang=en&modules=Spinner|ext.tmh.embedPlayerIframe|jquery.loadingSpinner%2CmwEmb…:193
each				@	load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:384
$.fn.triggerQueueCallback	@	load.php?debug=true&lang=en&modules=Spinner|ext.tmh.embedPlayerIframe|jquery.loadingSpinner%2CmwEmb…:192
checkPlayerSources		@	mw.EmbedPlayer.js?adda9:611
(anonymous function)		@	mw.processEmbedPlayers.js?209a7:115
$.fn.triggerQueueCallback	@	load.php?debug=true&lang=en&modules=Spinner|ext.tmh.embedPlayerIframe|jquery.loadingSpinner%2CmwEmb…:163
runPlayerSwap			@	mw.processEmbedPlayers.js?209a7:112
addPlayerElement		@	mw.processEmbedPlayers.js?209a7:131
(anonymous function)		@	mw.processEmbedPlayers.js?209a7:342
each				@	load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:384
each				@	load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=f47W3i0j:136
mw.processEmbedPlayers		@	mw.processEmbedPlayers.js?209a7:334
(anonymous function)		@	jquery.embedPlayer.js?be9ff:43

and the player doesn't appear eather, just a still-frame.

Event Timeline

Josve05a created this task.Jun 28 2016, 3:01 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 28 2016, 3:01 PM
Restricted Application added subscribers: Poyekhali, Steinsplitter. · View Herald TranscriptJun 28 2016, 4:10 PM
brion added a subscriber: brion.Jun 28 2016, 5:09 PM

What browser version is this exactly? I cannot reproduce any error output in Chrome 51.0.2704.103 (64-bit) for Mac at https://commons.wikimedia.org/wiki/File:New_medical_editor.ogv?embedplayer=yes

brion claimed this task.Jun 28 2016, 5:17 PM

(I think that's Chrome OS, so I'm downloading a virtual machine to test.)

Josve05a added a comment.EditedJun 28 2016, 5:24 PM
17:14:28 <Josve05a> Chrome
17:14:40 <Josve05a> 51.0.2704.103 (64-bit)
17:14:48 <Josve05a> on a Chromebook with ChromeOS
17:16:25 <Josve05a> well..when it "broke" like this the first time I opened the link (pressed it on IRC), the second time I pasted the llink, then it worked, and the third time I pasted the link in a new tab, it "broke" again
17:16:58 <Josve05a> so, it worked once for me...so seems like there must be another factor in there...
17:19:21 <Josve05a> in the 'broken version', the player never appared, just showed the still image in full-screen (of the browser)
brion added a comment.Jun 28 2016, 5:30 PM

My VM is super out of date (Chromium OS claiming version 32.0.1700.70, platform 3920.72.2014_01_23_1448 (Parallels Build)... No trouble with the linked page either.

Version 51.0.2704.103 (64-bit)
Plattform 8172.56.0 (Official Build) stable-channel glimmer
Fast programvara Google_Glimmer.5216.198.19

This comment was removed by Josve05a.

brion added a comment.Jun 28 2016, 6:53 PM

Summary of IRC discussion from earlier today:

  • bug pretty consistently happens for @Josve05a in regular browser window, but not in an Incognito window
  • happens on both Commons and English Wikipedia using this file
  • we ruled out differences in the HTML due to user options; HTML seems the same
  • doesn't seem to be user JS/gadgets; they don't _appear_ to leak into the embedded video view (which doesn't use standard skin output) and haven't managed to repro with copies of common.js
  • might or might not be affected by browser add-ons

So, last theory was browser add-ons, which should be testable. If not that, then we'll have to do another debugging session. :)

Same as with T107968: [Regression pre-wmf18] TypeError: Cannot read property 'split' of undefined this seems to be an issue due to the Chrome extention "Oribi Speak for Chrome" (ID: fncckpnmcmjoigmdohabblgilljambfi) which my school has force-installed on this device, and I can't uninsall it. SO, it seems a though there is no bug on WIkimedia's side...damn this F-ing add-on...

Actually, this is a duplicate of that bug. I "fixed" the bug in that ticket, by using AdBlocker to "hide/remove" the script from the website. Recomending merging this with that bug, and just marking it as invalid/declined...