Page MenuHomePhabricator

Issues with iOS
Closed, DeclinedPublic

Description

I found few more issues with iOS while testing https://phabricator.wikimedia.org/T138699. See attachment for reference.

  • What's with the labels?
  • After I select a source language but before I select a Target the following error appears: "Invalid source or target language". It disappears after I select a Target.
  • There is some issue with scrolling when seeing a preview. The background page scrolls and interferes when I want to scroll the preview dialog.
  • tapping on hamburger menu does not work

Event Timeline

Sabya updated the task description. (Show Details)
Sabya moved this task from Backlog to in-progress on the GapFinder board.

I've found the reason behind the issues. The expression var browserLanguages = navigator.languages || [ navigator.language || navigator.userLanguage ]; assigns 'en-us' in iOS/Mac safari, but in Chrome, it assigns 'en'. en-us could not be found in the sourceLanguages hence it becomes undefined by the following filter:

browserLanguages = browserLanguages.filter(function (language) {
    return language in sourceLanguages;
});

I think there are few approaches to solve this.

  • If the language code is not define, we should fall back to 'en'.
  • we can add 'en-us' in the sourceLanguages of uls
  • if the language code does not exist in our source languages, we could try to remove the coutry code along with the hyphen and run the filter again.

I think first approach is simple and should be done anyway to prevent completely breaking in case a language is not found.

Whaty say?

@Sabya, for the en-US issue, there's a different task to fix this: T130044

There's no problem that I see with having nothing pre-selected in the dropdown, except for the fact that the i18n isn't loaded until selecting a language. I think using english would be appropriate for a default localization, but not as a default source.

@Sabya since we haven't heard back from you, we are going to remove this from your todo list. :) Please feel free to claim it back if you have time to work on it. Your contributions are always welcomed here.

leila removed Sabya as the assignee of this task.Aug 30 2016, 4:13 PM
leila moved this task from in-progress to Backlog on the GapFinder board.
leila triaged this task as High priority.Sep 21 2016, 3:45 PM
schana moved this task from Backlog to Next Up on the GapFinder board.
Aklapper subscribed.

Resetting task assignee, as that user account is not active anymore.