Page MenuHomePhabricator

CentralNotice: Stop adding old, empty bannerController modules to HTML
Closed, ResolvedPublic1 Estimated Story Points


As part of last year's refactoring, we replaced ext.centralNotice.bannerController and with ext.centralNotice.startUp. However, we never actually stopped adding the old modules to page HTML; instead, they were added as empty modules, with the new code as dependencies.

To simplify some minor code changes suggested by other teams, it would be useful to finally move forward with this simple change, and stop adding the old modules. One month after that (once all the Varnish cache clears) we should be able to fully remove their declarations from the code.

See Stage 2: New modules added to cached HTML.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 28 2016, 7:49 PM

Change 296493 had a related patch set uploaded (by AndyRussG):
Request startUp and geoIP RL modules instead of bannerController

Change 296493 merged by jenkins-bot:
Request startUp and geoIP RL modules instead of bannerController

AndyRussG closed this task as Resolved.Jul 13 2016, 5:27 PM
AndyRussG moved this task from Backlog to Done on the Fundraising Sprint Muggle Baiting board.