i.e. does not take bundle counting into account:
When collapsed, it says I have 3 messages, but the counter says 5 and when expanded I see two bundles of 2 and one single message, so 5 is the correct number.
i.e. does not take bundle counting into account:
When collapsed, it says I have 3 messages, but the counter says 5 and when expanded I see two bundles of 2 and one single message, so 5 is the correct number.
mediawiki/extensions/Echo : master | Fix foreign bundle count |
Change 296574 had a related patch set uploaded (by Sbisson):
Fix foreign bundle count
e.g. User cawiki has only cross-wiki Alerts and Messages
Open Messages (the flyout counter shows 7, the cross-wiki sub-panel counter shows 15 again )
Expand it - the number of cross-wiki notifications is actually 7(6+1), the same count as in the flyout.
Created a simpler example - User:ET91 has 5 events according to db:
3 events in cawiki -
[cawiki]> select event_id, event_type, event_deleted from echo_event join echo_notification on notification_event=event_id where notification_user in (select user_id from user where user_name='ET91'); +----------+------------+---------------+ | event_id | event_type | event_deleted | +----------+------------+---------------+ | 1279 | welcome | 0 | | 1280 | mention | 0 | | 1281 | mention | 0 | +----------+------------+---------------+ 3 rows in set (0.00 sec)
2 events in enwiki -
[enwiki]> select event_id, event_type, event_deleted from echo_event join echo_notification on notification_event=event_id where notification_user in (select user_id from user where user_name='ET91'); +----------+----------------+---------------+ | event_id | event_type | event_deleted | +----------+----------------+---------------+ | 307211 | emailuser | 0 | | 307316 | flow-new-topic | 0 | +----------+----------------+---------------+ 2 rows in set (0.00 sec)
(CORRECT) Alerts in cawiki will display two Mentions
Switching to enwiki - cawiki there will have incorrect count:
enwiki Messages - cawiki count is incorrect
Expand cawiki Messages subpanel - only 'Welcome' is displayed:
The specific issue described in this task - count correctly bundled messages in cross-wiki counter - has been fixed, e.g. Cross-wiki sub-panel shows 6 messages from 3 wikis:
ruwiki - 3 msgs
enwiki - 2 msgs
metawiki - 1 msg
They counted correctly by the cross-wiki counter as 6 msgs