Page MenuHomePhabricator

Consider changing the highlight color in the Find and Replace tool
Open, MediumPublic1 Estimated Story Points

Assigned To
None
Authored By
Elitre
Jun 29 2016, 8:27 AM
Referenced Files
F4217697: pasted_file
Jun 30 2016, 6:32 PM
F4216542: pasted_file
Jun 30 2016, 2:00 PM
F4216197: pasted_file
Jun 30 2016, 11:39 AM
F4216208: pasted_file
Jun 30 2016, 11:39 AM
F4216222: pasted_file
Jun 30 2016, 11:39 AM
F4216210: pasted_file
Jun 30 2016, 11:39 AM
F4216215: pasted_file
Jun 30 2016, 11:39 AM
F4216213: pasted_file
Jun 30 2016, 11:39 AM

Description

Ziko says that he's using VE's Search function looking for the first time a certain word is mentioned, so that he can add a link to it.
The green highlight color behind occurrences of the word makes it difficult to figure out whether the marked text is already linked or not, though. So can that color be changed to something different perhaps?

Event Timeline

It could, but experimenting it seems any colour reduces the contrast between links and non-links significantly (it isn't very high to begin with). It doesn't help that we have to draw the highlights on top of the text.

current:

pasted_file (32×166 px, 3 KB)

hue rotations:
pasted_file (28×162 px, 3 KB)

pasted_file (31×163 px, 3 KB)

pasted_file (28×162 px, 3 KB)

pasted_file (30×163 px, 3 KB)

pasted_file (28×164 px, 3 KB)

pasted_file (32×165 px, 3 KB)

pasted_file (28×163 px, 3 KB)

Blue actually has a quite high contrast - but could be confused with a normal selection.

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Thanks, Ed; I'm content that the current colour is sufficient.

So this is declined?

The consideration was accepted and done; the decision is to stay as we are.

I don't actually object to a different shade of green, or even purple/pink, if that helps.

pasted_file (31×163 px, 3 KB)

Blue actually has a quite high contrast - but could be confused with a normal selection.

I like this one. It's a totally different blue from selection highlight, I think? also, normal selection changes the color of the font.

I guess that depends on browsers etc.

We don't override Firefox because it doesn't (yet) let use set the selection colour consistently:

pasted_file (27×92 px, 1 KB)

How about the following: underline a link when marked.

Links can be partially highlighted so that would require modifying the view which would lead to many more problems.

Ok, I see the problem. Thanks anyway for taking the effort.

Deskana renamed this task from Consider changing the highlight color in the Search tool to Consider changing the highlight color in the Find and Replace tool.Oct 13 2017, 9:36 AM
Deskana moved this task from TR1: Releases to Freezer on the VisualEditor board.