Page MenuHomePhabricator

Fix references to git.wikimedia.org in all repos
Closed, ResolvedPublic

Description

https://github.com/search?q=org%3Awikimedia+%22git.wikimedia.org%22&type=Code

At first, those which are not handled by current redirecting rules (particularly those which have repo name without trailing .git) should be fixed. Also the origin and destination link type should be reported here for purpose to potentially add new redirecting rules.

Next step should be fixing of all other links which are redirected now (then the priority of this task can be lowered).

Details

Commits
rODBMcf5dda7e2eab: git.wikimedia.org -> phab
rANKAc24b65b42420: git.wikimedia.org -> phab
rTLST9ddfb17eb548: git.wikimedia.org -> phab
rANGW9a0e7187da75: git.wikimedia.org -> phab
rANGWa2725092cc14: git.wikimedia.org -> phab
rODNFS7f0faf5d0a7f: git.wikimedia.org -> phab
rOSSUe78c136580f4: git.wikimedia.org -> phab
rPWDTb0efe0e5b180: git.wikimedia.org -> phab
rWWSC4950644eebff: git.wikimedia.org -> phab
rMWVAf17f369c57df: git.wikimedia.org -> phab
rWWSCefdc4fbd77f7: git.wikimedia.org -> phab
rANGW59f92e3b7cd4: git.wikimedia.org -> phab
rGOJU8fbaa3da4b59: git.wikimedia.org -> phab
rWWSC457ff4b57d11: git,wikimedia.org -> phab
rWFTOf904c6874eb2: git.wikimedia.org -> phab
rELIT229e1e82939e: git.wikimedia.org -> phab
rETDAe96cfab0d179: git.wikimedia.org -> phab
rEMBP2fc306b442ac: git.wikimedia.org -> phab
rEZBA436fe568813f: git.wikimedia.org -> phab
rEPCR875bcc0ed60c: git.wikimedia.org -> phab
rEPIE715fc9a0d997: git.wikimedia.org -> phab
rEGTO9f929a1d2448: git.wikimedia.org -> phab
rEGTO8447936f21e3: git.wikimedia.org -> phab
rEGSTf4250097e673: Update git.wikimedia.org URL to Phabricator
rMSTED4ddab051ffb7: git.wikimedia.org -> phab
rMWebfdff32a425: Language: Update git.wikimedia.org URLs to point to Phabricator
rGMADf8e0234ff440: git.wikimedia.org -> phab
rMDEBd27b0179fd89: git.wikimedia.org -> phab
rEPTH965bf05ddc1e: git.wikimedia.org -> phab
rECTCdc27d7cc15d3: git.wikimedia.org -> phab
rECLP2833954c16a3: git.wikimedia.org -> phab
rECLPfc48aaaf72c4: git.wikimedia.org
rOSSU12199e0c829a: git.wikimedia.org -> phab
rEOIDe9b660fe70b7: git.wikimedia.org -> phab
rEWLD23847faa42bd: git.wikimedia.org -> phab
rEPHDaa1420a58d90: git.wikimedia.org -> phab
rAPAJ9d2b2592c697: git.wikimedia.org -> phab
rEAWK56d82ac7f563: git.wikimedia.org -> phab
rEWLDc9d6f26c7c91: git.wikimedia.org -> phab
rEPFM83c12e285844: git.wikimedia.org -> phab
rELINad924ae29bc9: git.wikimedia.org -> phab
rETAB8b5cbe6767a8: git.wikimedia.org -> phab
rGUJSb4388d1d0a88: git.wikimedia.org -> phab
rESIIdea38eaf3db5: git.wikimedia.org -> phab
rEWLO0b18b6193edc: git.wikimedia.org -> phab
rEPTR9d4234bae6f0: git.wikimedia.org -> phab
rECIR5fb85c15d8e1: git.wikimedia.org -> phab
rEGGC59b20f76fb68: git.wikimedia.org -> phab
rEWLO1f91b4f92e41: git.wikimedia.org -> phab
rEPHDc983ca7799d9: git.wikimedia.org -> phab
rAPAJ51a3a48f42ce: git.wikimedia.org -> phab

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 389329 merged by jenkins-bot:
[mediawiki/extensions/PCRGUIInserts@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389329

Change 389328 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389328

@Umherirrender weird, GitHub's search shows a lot more, tho that could just be due to the search not being updated or it being cached.

https://github.com/search?q=org%3Awikimedia+%22git.wikimedia.org%22&type=Code gives 109 results, and 38 of those results are in PHP files.

Some of the extensions gets archived, see T178768 for an example.

Ah, thanks. Also could you please re-run the search? I've submitted patches for the results you pasted above, but I want to be sure I got all of them.

Looks all good now in mediawiki/extensions and mediawiki/core

Change 389652 had a related patch set uploaded (by Chad; owner: Chad):
[wikimedia/wikimania-scholarships@master] Fix a few remaining git.wikimedia.org references

https://gerrit.wikimedia.org/r/389652

demon added a subscriber: demon.Nov 7 2017, 12:10 AM

Looks all good now in mediawiki/extensions and mediawiki/core

Really? I see lots of mentions still

Change 389652 merged by jenkins-bot:
[wikimedia/wikimania-scholarships@master] Fix a few remaining git.wikimedia.org references

https://gerrit.wikimedia.org/r/389652

Change 389655 had a related patch set uploaded (by Chad; owner: Chad):
[operations/software/varnish/libvmod-netmapper@master] Swap git.wikimedia.org -> phabricator.wikimedia.org

https://gerrit.wikimedia.org/r/389655

Looks all good now in mediawiki/extensions and mediawiki/core

Really? I see lots of mentions still

I am refer to the mediawiki/extensions git repo with all its submodule. There are still extensions in the github search results, but that looks like old code, which needs to be removed from the repos.

demon added a comment.Nov 7 2017, 5:19 PM

Some of it. Not all of it. I'm slowly fixing the rest.

Change 389906 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[analytics/refinery/source@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389906

Change 389907 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[analytics/geowiki@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389907

Change 389906 merged by jenkins-bot:
[analytics/refinery/source@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389906

Change 389914 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[oojs/ui@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389914

Change 389915 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[wikimedia/fundraising/tools@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389915

Change 389918 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[pywikibot/bots/drtrigonbot@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389918

Change 389920 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[wikimedia/wikimania-scholarships@master] git,wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389920

Change 389914 merged by jenkins-bot:
[oojs/ui@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389914

Change 389921 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[mediawiki/vagrant@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389921

Change 389918 merged by Xqt:
[pywikibot/bots/drtrigonbot@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389918

Change 389655 merged by BBlack:
[operations/software/varnish/libvmod-netmapper@master] Swap git.wikimedia.org -> phabricator.wikimedia.org

https://gerrit.wikimedia.org/r/389655

Change 389920 merged by jenkins-bot:
[wikimedia/wikimania-scholarships@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389920

Change 389915 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389915

Change 389921 merged by jenkins-bot:
[mediawiki/vagrant@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389921

Change 390003 had a related patch set uploaded (by Chad; owner: Chad):
[analytics/refinery/source@master] Swap git.wikimedia.org -> phabricator.wikimedia.org

https://gerrit.wikimedia.org/r/390003

Change 390006 had a related patch set uploaded (by Chad; owner: Chad):
[analytics/geowiki@master] Fix git.wikimedia.org -> phabricator.wikimedia.org

https://gerrit.wikimedia.org/r/390006

Change 390003 merged by Chad:
[analytics/refinery/source@master] Swap git.wikimedia.org -> phabricator.wikimedia.org

https://gerrit.wikimedia.org/r/390003

demon updated the task description. (Show Details)Nov 8 2017, 4:07 PM

Change 390013 had a related patch set uploaded (by Chad; owner: Chad):
[VisualEditor/VisualEditor@master] git.wikimedia.org removals

https://gerrit.wikimedia.org/r/390013

Change 390013 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] git.wikimedia.org removals

https://gerrit.wikimedia.org/r/390013

Change 390020 had a related patch set uploaded (by Chad; owner: Chad):
[maps/tilerator@master] git.wm.o -> phab.wm.o

https://gerrit.wikimedia.org/r/390020

Change 390020 abandoned by Chad:
git.wm.o -> phab.wm.o

https://gerrit.wikimedia.org/r/390020

Change 390021 had a related patch set uploaded (by Chad; owner: Chad):
[maps/tilerator@master] git.wm.o -> phab.wm.o

https://gerrit.wikimedia.org/r/390021

Change 390023 had a related patch set uploaded (by Chad; owner: Chad):
[maps/kartotherian@master] git.wm.o -> phab.wm.o

https://gerrit.wikimedia.org/r/390023

Change 390023 merged by Chad:
[maps/kartotherian@master] git.wm.o -> phab.wm.o

https://gerrit.wikimedia.org/r/390023

Change 390006 abandoned by Chad:
Fix git.wikimedia.org -> phabricator.wikimedia.org

Reason:
Ib5af27ea

https://gerrit.wikimedia.org/r/390006

Change 390026 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[operations/software/swift-utils@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390026

Change 390035 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[analytics/wikistats@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390035

Change 390035 merged by Chad:
[analytics/wikistats@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390035

Change 390043 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[operations/debs/mwbzutils@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390043

Change 390043 abandoned by TerraCodes:
git.wikimedia.org -> phab

Reason:
per chad's comment

https://gerrit.wikimedia.org/r/390043

Change 390050 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[operations/debs/nfsd-ldap@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390050

Change 390175 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[operations/debs/logster@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390175

Change 390026 merged by Filippo Giunchedi:
[operations/software/swift-utils@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390026

Change 390326 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[analytics/kafkatee@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390326

Change 390329 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[labs/tools/lists@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390329

demon added a comment.EditedNov 9 2017, 10:15 PM

As pointed out, they're part of a library and will get automatically fixed when it's next pulled in.

Change 390334 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[wikimedia/discovery/wonderbolt@develop] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390334

Change 390334 abandoned by Chad:
git.wikimedia.org -> phab

Reason:
Already did this one

https://gerrit.wikimedia.org/r/390334

Change 390336 had a related patch set uploaded (by TerraCodes; owner: TerraCodes):
[wikimedia/fundraising/dash@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390336

Change 390336 merged by Chad:
[wikimedia/fundraising/dash@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390336

Change 390326 merged by Chad:
[analytics/kafkatee@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390326

Change 390175 merged by Chad:
[operations/debs/logster@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390175

Change 390050 merged by Chad:
[operations/debs/nfsd-ldap@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390050

Change 389907 merged by Chad:
[analytics/geowiki@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/389907

Change 390021 merged by Chad:
[maps/tilerator@master] git.wm.o -> phab.wm.o

https://gerrit.wikimedia.org/r/390021

demon added a comment.Nov 9 2017, 11:12 PM

Ok, so here's where we stand:

False positives (this could be due to a library that needs updating, changelog entries, or ok stuff like redirects in puppet):

  • mediawiki-debian (x6)
  • puppet (x7)
  • unicodejs
  • grunt-banana-checker
  • VisualEditor
  • analytics-limn-wikidata-data-vendor
  • phabricator-extensions
  • oojs
  • oojs-ui

Needs fixing still:

  • labs-tools-lists (patch in progress)
  • pywikibot-core
  • pywikibot-bots-drtrigonbot (same as above?)

So once these final 3 are done, we can close this.

what would be the phab version of gitblit's /feed/?
https://git.wikimedia.org/feed/pywikibot/core

demon added a comment.Nov 9 2017, 11:35 PM

There isn't an RSS feed of commits (cf: upstream T5381). Also, that code looks pretty fragile to begin with. I'd like to get a Pywikibot dev to weigh in here...

The one from drtrigonbot looks easily fixable by the author (although it's an unused code path to begin with, callers all commented out)

The one from drtrigonbot looks easily fixable by the author (although it's an unused code path to begin with, callers all commented out)

Only half of the lines are commented out tho?

Lines 90 and 97 are commented out, but 91 and 98 aren't.

demon added a comment.Nov 9 2017, 11:53 PM

I mean the callers to _get_git() and _get_git_path() are commented out, lines 152, 154, 185, 193.

I mean the callers to _get_git() and _get_git_path() are commented out, lines 152, 154, 185, 193.

Oh.

I'll fix the Pywikibot usage.

Change 390362 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[pywikibot/core@master] version: Don't rely on git.wikimedia.org

https://gerrit.wikimedia.org/r/390362

jayvdb added a subscriber: jayvdb.Nov 10 2017, 2:33 AM

Let me know if you need help with code review for pywiki

Change 390362 merged by jenkins-bot:
[pywikibot/core@master] version: Don't rely on git.wikimedia.org

https://gerrit.wikimedia.org/r/390362

mwjames removed a subscriber: mwjames.Nov 11 2017, 10:25 AM
demon closed this task as Resolved.Nov 13 2017, 6:04 PM

Everything is done other than this change up for review, the unused codepaths in drtrigonbot discussed above, and various false positives (ok stuff in puppet, changelogs mentioning it, libraries that will eventually update from their upstream).

Resolving.

Change 391137 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d9059cd50)

https://gerrit.wikimedia.org/r/391137

Change 390329 merged by Incola:
[labs/tools/lists@master] git.wikimedia.org -> phab

https://gerrit.wikimedia.org/r/390329