Page MenuHomePhabricator
Create Task
Maniphest T139092

Images that are not part of core article content are being included in image gallery list
Closed, ResolvedPublic
Actions

Assigned To
Mhurd
Authored By
RHo
Jun 30 2016, 6:12 PM
Tags
Referenced Files
F4217633: Mel Brooks 3.png
Jun 30 2016, 6:12 PM
F4217613: Nigel 1.png
Jun 30 2016, 6:12 PM
F4217616: Nigel 4.png
Jun 30 2016, 6:12 PM
F4217629: Mel Brooks 2.png
Jun 30 2016, 6:12 PM
F4217617: Nigel 2.png
Jun 30 2016, 6:12 PM
F4217632: Mel Brooks 4.png
Jun 30 2016, 6:12 PM
F4217631: Mel Brooks 1.png
Jun 30 2016, 6:12 PM
F4217612: Nigel 3.png
Jun 30 2016, 6:12 PM
Subscribers
Aklapper
• Deskana
• Fjalapeno
• JMinor
Nicholas.tsg
RHo
Zppix

Description

Images, often small badges or logos that are not part of 'core' article content are being included when user views images in the full screen gallery.

Occurring on:
iPhone 6S Plus, OS 9.3.2
Wikipedia app 5.0.5.891

Steps to reproduce:

  1. Open an article with images (eg., Nigel Farage, Mel Brooks)
  2. Tap on the first lead image to view it in full screen
  3. Swipe to view all other images in the article.

Expected:
Only images that are part of the main article content should be included

Actual:
Some small unrelated/insignificant images are also included in the list of images.

Example 1.

Nigel Farage
Nigel 1.png (2×1 px, 1 MB)
Image in 'Political career' section
Nigel 2.png (2×1 px, 2 MB)
Unrelated icon about article freshness
Nigel 3.png (2×1 px, 863 KB)
Image in 'Persona life' section
Nigel 4.png (2×1 px, 2 MB)

Example 2.

Mel Brooks
Mel Brooks 1.png (2×1 px, 1 MB)
Full screen image list shows vector icons...
Mel Brooks 3.png (2×1 px, 2 MB)
... amongst content images
Mel Brooks 4.png (2×1 px, 2 MB)
Icons are actually from info box
Mel Brooks 2.png (2×1 px, 257 KB)

Related Objects

Event Timeline

RHo created this task.Jun 30 2016, 6:12 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 30 2016, 6:12 PM
RHo updated the task description. (Show Details)Jun 30 2016, 6:12 PM
• Deskana subscribed.Jun 30 2016, 6:15 PM

This isn't happening on the Android app, so whatever solution is in place there could probably be re-used on iOS.

• JMinor triaged this task as Low priority.Jun 30 2016, 6:19 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor added a project: iOS-app-v5.0.5-Fever.
• JMinor subscribed.

I believe this is a regression, as we had essentially matched the Android criteria during 5.0.0

• Deskana added a comment.Jun 30 2016, 6:22 PM

This is possibly the relevant bit: https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/java/org/wikipedia/page/gallery/GalleryCollection.java#L50-L65

Images that are too small are ignored, which includes most of these miscellaneous images like the flags and logos.

RHo added a comment.Jun 30 2016, 6:25 PM

I believe it is regression since these same articles ignore the smaller images on
v5.0.5.889.1 yesterday, and only appeared today on v5.0.5.891.

RHo updated the task description. (Show Details)Jun 30 2016, 6:25 PM
• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.0.5-Fever board.Jun 30 2016, 6:26 PM
• JMinor mentioned this in T138358: Regression with gifs not making it to the cache. Makes them not appear in gallery..Jun 30 2016, 6:35 PM
Mhurd moved this task from Ready for Development to Verify Test Coverage on the iOS-app-v5.0.5-Fever board.Jul 6 2016, 6:07 PM
Mhurd moved this task from Verify Test Coverage to Needs QA on the iOS-app-v5.0.5-Fever board.

https://github.com/wikimedia/wikipedia-ios/pull/747

RHo moved this task from Needs QA to Blocked or Waiting on the iOS-app-v5.0.5-Fever board.Jul 6 2016, 8:18 PM

@Mhurd oh dear, the bug is back on the latest beta :(
See Mel Brooks and Nigel Farage again...

Mhurd added a comment.Jul 6 2016, 8:20 PM

@RHo can you double-check that you're using the right beta? I'm not seeing it...

Mhurd added a comment.Jul 6 2016, 8:21 PM

@RHo this was just merged a couple hrs ago btw. If your beta is earlier that would explain it :)

RHo added a comment.Jul 6 2016, 8:26 PM

@Mhurd hmmm I think this is the latest beta from today - v5.0.5.893

Bug appearing on both iPad mini 2 and iPhone 6S Plus.

RHo added a comment.Jul 6 2016, 8:37 PM

Ok just checked and bug is on the latest beta v 893, but fixed on the most recent develop branch (PR merge #860).

• Fjalapeno moved this task from Blocked or Waiting to Needs Testing Criteria on the iOS-app-v5.0.5-Fever board.Jul 6 2016, 8:37 PM
• Fjalapeno subscribed.Jul 7 2016, 3:09 AM

To test:

  1. Follow the steps to repro in the ticket description
  2. Verify only images that are part of the main content are in the gallery
• Fjalapeno moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.0.5-Fever board.Jul 7 2016, 3:09 AM
• JMinor added a comment.Jul 7 2016, 7:10 PM

Seems fixed again as of 896.1

This has regressed more than once, and I'd suggest this might be a good target for automation.

RHo added a comment.EditedJul 11 2016, 3:59 PM

This regression appears to be fixed on app version 5.0.5.900.1 (tested on the iPhone 6S Plus and iPad mini 2)

RHo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.0.5-Fever board.Jul 11 2016, 4:10 PM
Nicholas.tsg subscribed.Jul 11 2016, 9:34 PM

Tested on iOS 9.3.2 with iPhone, and latest Wikipedia 5.0.5 (900.1) app build. This is fixed as the Nigel Farage and Mel Brooks articles no longer show unrelated/insignificant images during image swiping.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.0.5-Fever board.Jul 11 2016, 10:52 PM
• JMinor closed this task as Resolved.Jul 26 2016, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL