[regression-betalabs] 'Failed to fetch notifications'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jun 30 2016, 8:41 PM

Description

The badges do not change their colors after clicking. Special:Notifications page will display unread messages with the correct count. No errors in the Console.

Note: Special:Notificaitons displays all notifications correctly; only the flyout shows "Failed to fetch notifications".
Note: 'Failed to fetch notifications' is displayed when only local unread notifications are present.
The same user - in cawiki, English Alert is visible; in enwiki - Alert displays 'Failed to fetch notifications'

Screen Shot 2016-06-30 at 1.58.17 PM.png (250×609 px, 27 KB)

Screen Shot 2016-06-30 at 1.57.58 PM.png (362×579 px, 45 KB)

Network tab shows:

"#0 /srv/mediawiki/php-master/extensions/Echo/includes/api/ApiEchoNotifications.php(119): 
ApiEchoNotifications->makeForeignNotification(User, string, string) 
#1 /srv/mediawiki/php-master/extensions/Echo/includes/api/ApiEchoNotifications.php(44): ApiEchoNotifications->getLocalNotifications(array) 
#2 /srv/mediawiki/php-master/includes/api/ApiQuery.php(251): 
ApiEchoNotifications->execute() #3 /srv/mediawiki/php-master/includes/api/ApiMain.php(1374): 
ApiQuery->execute() 
#4 /srv/mediawiki/php-master/includes/api/ApiMain.php(470): ApiMain-
>executeAction() 
#5 /srv/mediawiki/php-master/includes/api/ApiMain.php(441): ApiMain-
>executeActionWithErrorHandling() 
#6 /srv/mediawiki/php-master/api.php(83): ApiMain->execute() 
#7 /srv/mediawiki/w/api.php(3): include(string) 
#8 {main}"

Some other examples:

Screen Shot 2016-06-29 at 9.28.13 AM.png (422×1 px, 77 KB)

Screen Shot 2016-06-30 at 1.31.23 PM.png (401×1 px, 124 KB)

Screen Shot 2016-06-30 at 1.34.52 PM.png (666×1 px, 230 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ApiEchoNotifications: Don't add wikis with no timestamp	mediawiki/extensions/Echo	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T139323: Bundled notifications: The counter for bundled notifications shows sum of notifications of Alerts and Messages.
T138888: Cross-wiki counter does not show correct number of unread messages

Event Timeline

Etonkovidova created this task.Jun 30 2016, 8:41 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 30 2016, 8:41 PM

Etonkovidova updated the task description. (Show Details)Jun 30 2016, 9:02 PM

Etonkovidova updated the task description. (Show Details)Jun 30 2016, 9:19 PM

Etonkovidova mentioned this in T138888: Cross-wiki counter does not show correct number of unread messages.Jun 30 2016, 10:39 PM

Etonkovidova updated the task description. (Show Details)Jun 30 2016, 10:56 PM

Catrope triaged this task as Unbreak Now! priority.Jul 1 2016, 1:30 PM

Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.

Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptJul 1 2016, 1:30 PM

I've seen this in @Etonkovidova 's computer, but when I try with my user, I don't see this error on beta labs and in master. Both Special:Notifications page and the popups load perfectly for me without errors.

@Etonkovidova, could it be an error with the specific user? Can you try with another user and see if that happens again?

@Mooeypoo - Adding error info:

error: {code: "internal_api_error_BadMethodCallException",…}
*:"#0 /srv/mediawiki/php-master/extensions/Echo/includes/api/ApiEchoNotifications.php(373): Closure$ApiEchoNotifications::makeForeignNotification#3(string, string)
#1 /srv/mediawiki/php-master/extensions/Echo/includes/api/ApiEchoNotifications.php(119): ApiEchoNotifications->makeForeignNotification(User, string, string)
#2 /srv/mediawiki/php-master/extensions/Echo/includes/api/ApiEchoNotifications.php(44): ApiEchoNotifications->getLocalNotifications(array)
#3 /srv/mediawiki/php-master/includes/api/ApiQuery.php(251): ApiEchoNotifications->execute()
#4 /srv/mediawiki/php-master/includes/api/ApiMain.php(1376): ApiQuery->execute()
#5 /srv/mediawiki/php-master/includes/api/ApiMain.php(472): ApiMain->executeAction()
#6 /srv/mediawiki/php-master/includes/api/ApiMain.php(443): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-master/api.php(83): ApiMain->execute()
#8 /srv/mediawiki/w/api.php(3): include(string)
#9 {main}"

code:"internal_api_error_BadMethodCallException"

info:
"[V3ak1wpEEH8AAD2W6LMAAAAN] Exception Caught: Call to a member function getTimestamp() on a non-object (null)"

servedby:"deployment-mediawiki02"

Etonkovidova updated the task description. (Show Details)Jul 1 2016, 6:15 PM

Change 296956 had a related patch set uploaded (by Catrope):
ApiEchoNotifications: Don't add wikis with no timestamp

https://gerrit.wikimedia.org/r/296956

gerritbot added a project: Patch-For-Review.Jul 1 2016, 7:18 PM

Change 296956 merged by jenkins-bot:
ApiEchoNotifications: Don't add wikis with no timestamp

https://gerrit.wikimedia.org/r/296956

Catrope claimed this task.Jul 1 2016, 7:42 PM

Catrope moved this task from Ready for Pickup to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 1 2016, 8:00 PM

Danny_B added a project: Regression.Jul 1 2016, 9:00 PM

Checked the fix in betalabs - no more 'Failed to fetch notifications' messages displayed.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 4 2016, 4:09 PM

Etonkovidova mentioned this in T139323: Bundled notifications: The counter for bundled notifications shows sum of notifications of Alerts and Messages..Jul 5 2016, 1:02 AM

• jmatazzoni closed this task as Resolved.Jul 5 2016, 6:45 PM

	F4218133: Screen Shot 2016-06-30 at 1.57.58 PM.png
	Jun 30 2016, 9:02 PM

	F4218130: Screen Shot 2016-06-30 at 1.58.17 PM.png
	Jun 30 2016, 9:02 PM

	F4218072: Screen Shot 2016-06-30 at 1.31.23 PM.png
	Jun 30 2016, 8:41 PM

	F4218074: Screen Shot 2016-06-30 at 1.34.52 PM.png
	Jun 30 2016, 8:41 PM

	F4218068: Screen Shot 2016-06-23 at 4.36.41 PM.png
	Jun 30 2016, 8:41 PM

	F4218070: Screen Shot 2016-06-29 at 9.28.13 AM.png
	Jun 30 2016, 8:41 PM

[regression-betalabs] 'Failed to fetch notifications' Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[regression-betalabs] 'Failed to fetch notifications'
Closed, ResolvedPublic
Actions