These are currently maintained via puppet in /etc/hosts, and don't make it into the containers. Let's move them into DNS so they can!
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Bstorm | T139190 Move tools-db and tools-redis into DNS | |||
| Resolved | taavi | T153810 Make switching Redis server simpler |
Event Timeline
Comment Actions
Change 296941 had a related patch set uploaded (by Yuvipanda):
labsdns: Allow returning arbitrary A records, not CNAMEs
Comment Actions
Change 296941 merged by Yuvipanda:
labsdns: Allow returning arbitrary A records, not CNAMEs
Comment Actions
Ok, right now it's implemented with a hacky lua script that requires a puppet change to change, but ideally should be implemented as:
- We add $projectname.wmflabs.org to the search list in /etc/resolv.conf, and then can add these as $thing.$projectname.wmflabs.org in horizon
- No step 2.
We already have two items in 'search' in /etc/resolv.conf, and there's a hard limit of 5, and kubernetes might add a couple more, so we have to examine that carefully...
Comment Actions
Change 296947 had a related patch set uploaded (by Yuvipanda):
labsdns: Add tools-redis to DNS alias as well
Comment Actions
Change 328453 had a related patch set uploaded (by Tim Landscheidt):
Tools: Remove redundant tools-db entry from /etc/hosts
Comment Actions
Change 328453 merged by Andrew Bogott:
Tools: Remove redundant tools-db entry from /etc/hosts
Comment Actions
It looks like this was actually done and we just never did the final cleanup in the hosts file.
$ dig @labs-recursor1.wikimedia.org. tools-redis.tools.eqiad.wmflabs ; <<>> DiG 9.9.5-3ubuntu0.17-Ubuntu <<>> @labs-recursor1.wikimedia.org. tools-redis.tools.eqiad.wmflabs ; (1 server found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 8160 ;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;tools-redis.tools.eqiad.wmflabs. IN A ;; ANSWER SECTION: tools-redis.tools.eqiad.wmflabs. 300 IN A 10.68.22.56 ;; Query time: 1 msec ;; SERVER: 208.80.154.20#53(208.80.154.20) ;; WHEN: Fri Aug 03 15:50:30 UTC 2018 ;; MSG SIZE rcvd: 65 $ dig @labs-recursor0.wikimedia.org. tools-redis.tools.eqiad.wmflabs ; <<>> DiG 9.9.5-3ubuntu0.17-Ubuntu <<>> @labs-recursor0.wikimedia.org. tools-redis.tools.eqiad.wmflabs ; (1 server found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 63192 ;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;tools-redis.tools.eqiad.wmflabs. IN A ;; ANSWER SECTION: tools-redis.tools.eqiad.wmflabs. 192 IN A 10.68.22.56 ;; Query time: 4 msec ;; SERVER: 208.80.155.118#53(208.80.155.118) ;; WHEN: Fri Aug 03 15:50:40 UTC 2018 ;; MSG SIZE rcvd: 65
Comment Actions
I noticed the same thing. I was actually curious if that hosts file is needed at all at this point.
Comment Actions
Change 450247 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] gridengine: remove puppetized hosts file
Comment Actions
Change 450247 merged by Bstorm:
[operations/puppet@production] gridengine: remove puppetized hosts file
Comment Actions
Change 450624 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] gridengine: remove variables that were for deleted template
Comment Actions
Change 450624 merged by Bstorm:
[operations/puppet@production] gridengine: remove variables that were for deleted template
Comment Actions
So for the final step of this (making svc domain for the redis server), it looks like that should be something like: https://gerrit.wikimedia.org/r/c/operations/puppet/+/397256
Comment Actions
Let's call this done. I was thinking about adding some service name like tools.redis.svc.eqiad.wmflabs for redis, but since this is really just for things inside the Toolforge project I am now thinking that the tools-redis.tools.eqiad.wmflabs name is fine. We already have tools.db.svc.eqiad.wmflabs up and working for the database component of this task.