Page MenuHomePhabricator
Create Task
Maniphest T139196

VisualEditor crashes while trying to delete a category on the second attempt
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to a page which already has a category in it
  2. Click on Delete icon for that category
  3. Click cancel on the dialog and that should retain the category back
  4. Now again open the dialog and try to delete the same category

Observed Result:
There is an error in the console:
VM71:489 Uncaught TypeError: Cannot read property 'metaItem' of undefined

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ensure widgets are always torn down when categories page is closedmediawiki/extensions/VisualEditormaster+17 -20
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Jul 1 2016, 5:56 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 1 2016, 5:56 PM
Ryasmeen renamed this task from VisualEditor crashes while trying to delete a category on the second attempt to [Regression pre-wmf.9] VisualEditor crashes while trying to delete a category on the second attempt.Jul 1 2016, 6:45 PM
Ryasmeen renamed this task from [Regression pre-wmf.9] VisualEditor crashes while trying to delete a category on the second attempt to VisualEditor crashes while trying to delete a category on the second attempt.
Esanders triaged this task as Low priority.Jul 2 2016, 4:24 PM
Esanders raised the priority of this task from Low to Medium.Jul 2 2016, 4:41 PM
gerritbot subscribed.Jul 2 2016, 4:41 PM

Change 297135 had a related patch set uploaded (by Esanders):
Ensure widgets are always torn down when categories page is closed

https://gerrit.wikimedia.org/r/297135

gerritbot added a project: Patch-For-Review.Jul 2 2016, 4:41 PM
Jdforrester-WMF closed this task as Resolved.Jul 4 2016, 7:08 AM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added: VisualEditor-MediaWiki; removed: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Jul 4 2016, 7:11 AM

Change 297135 merged by jenkins-bot:
Ensure widgets are always torn down when categories page is closed

https://gerrit.wikimedia.org/r/297135

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 4 2016, 8:00 AM
Ryasmeen added a project: Verified.Jul 5 2016, 10:06 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jul 7 2016, 5:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits