Page MenuHomePhabricator

Investigate building notification page titles from the namespace key and text
Closed, DeclinedPublic

Description

In Notification.fromJSON(), we currently build the title of the page related to the notification by using the full attribute of the data.title object.

However, a TODO comment suggested that we instead build it from the namespace-key and text attributes, which contain the namespace number and title (without namespace) of the page, respectively.

This task was opened as a result of the discussion on gerrit change I83e480d0 ("Fix notifications building from JSON").

Event Timeline

Xqt subscribed.

Don't see any advantage as long as the code works as expected