Page MenuHomePhabricator

[HeaderTabs] Accessing the .cssRules on an undefined var results in problems for later js
Open, HighPublic

Description

I installed the Popups extension and found that HeaderTabs was keeping it from working because its js was trying to use cursheet's properties when cursheet was not defined.

Patch incoming.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 2 2016, 2:58 PM

Change 297131 had a related patch set uploaded (by MarkAHershberger):
Make sure we don't try to use an undefined var as an object

https://gerrit.wikimedia.org/r/297131

MarkAHershberger triaged this task as High priority.

giving to Yaron so he can +2 the patch or provide feedback.

Aklapper renamed this task from Accessing the .cssRules on an undefined var results in problems for later js to [HeaderTabs] Accessing the .cssRules on an undefined var results in problems for later js.Jan 25 2019, 6:30 PM

Change 297131 abandoned by markahershberger:
Make sure we don't try to use an undefined var as an object

https://gerrit.wikimedia.org/r/297131

Aklapper removed Yaron_Koren as the assignee of this task.Jun 19 2020, 4:18 PM
Aklapper added a subscriber: Yaron_Koren.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)