Page MenuHomePhabricator

add title attribute to rank and value selection menue item
Closed, ResolvedPublic

Description

The entries in the pop-up menus for rank and value should have title attributes (or some other tooltip-mechanism) to show some additional information about the use of these elements.

titleranks.png (161×569 px, 21 KB)

Wording suggestion

  • valid and up-to-date value
  • valid value, though possibly historic
  • value is known to be wrong but (used to be) commonly believed

Event Timeline

Jan_Dittrich renamed this task from add title attribute to rank and value indicators to add title attribute to rank and value selection menue item.Jul 7 2016, 7:14 AM
thiemowmde added a subscriber: thiemowmde.

I would not expect tooltips on menu items, especially not tooltips that are crucial to understand a menu item. I suggest to make the visible text better instead, similar to T139578.

If we can improve the text, I'm much in favor of it. However, I wonder if we can find anything short, precise and (better) understandable.

I suppose adding a tooltip is an improvement. And it would not mean that we should stop improving the menu items themselves.

Yeah let's add the tooltips. They're not the perfect solution but better than the current state.

Lydia_Pintscher raised the priority of this task from Low to Medium.Sep 9 2016, 6:17 PM

@Jan_Dittrich or @Lydia_Pintscher could you please provide the texts for all the tooltips?

Why not go with the suggestion and change the visible menu items, e.g. from "Deprecated rank" to "Deprecated (known to be wrong)"? It should not be a full sentence and can still have a tooltip, but there is more than enough space left to add at least a few additional words. Why waste the opportunity?

If there is enough space, @thiemowmde suggestion sounds good.

So we could have:

  • Preferred Rank
  • Normal Rank
  • Deprecated (known to be wrong)

and for the tooltips:

  • valid and up-to-date value
  • valid value, though possibly out of date OR valid value. May be out of date.
  • value is known to be wrong but (used to be) commonly believed

do they make sense?

"valid value, though possibly out of date" is the better one of the two.

Rest looks good.

Thanks!
I assume that "historic" may be a bit more terse (also more precise?), but I would prefer "out of date" since I assume it to be the more common expression.

"out of date" is conceptually different from "historic" here. When we have a statement about a previous mayor including the time span then that is not out of date but historic.

OK, if no one has an idea that is more easy and as precise, let’s go with "historic".
The rest would stay as it is. (?)

In which case, I say it's ready – @thiemowmde , @Jonas : or is there anything missing that you would need know?

Jonas raised the priority of this task from Medium to High.Oct 12 2016, 9:05 AM

Change 315655 had a related patch set uploaded (by Jonas Kress (WMDE)):
Add title attribute to rank and value selection menu item

https://gerrit.wikimedia.org/r/315655

Change 315655 merged by jenkins-bot:
Add title attribute to rank and value selection menu item

https://gerrit.wikimedia.org/r/315655

hoo removed a project: Patch-For-Review.
hoo added a subscriber: hoo.

The tooltips have been added as discussed. Can we consider this done, or do we also want to adopt Thiemo's suggestion:

Why not go with the suggestion and change the visible menu items, e.g. from "Deprecated rank" to "Deprecated (known to be wrong)"? It should not be a full sentence and can still have a tooltip, but there is more than enough space left to add at least a few additional words. Why waste the opportunity?

Lydia_Pintscher moved this task from Backlog to Done on the Wikidata-Sprint-2016-10-12 board.

I would leave it for now.