Page MenuHomePhabricator

MediaWiki search label not accessible
Closed, ResolvedPublic

Description

See https://adactio.com/journal/10910.

It looks like we're using a label with for attribute. What that sounds good, it is inside an <h3> with display:none, so I don't think this actually works.

Event Timeline

Krinkle created this task.Jul 5 2016, 9:34 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptJul 5 2016, 9:34 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Danny_B moved this task from Unsorted to Attributes on the Accessibility board.Jul 5 2016, 9:45 PM

Good catch, that's definitely not accessible.
A case for .mixin-screen-reader-text() as introduced by https://gerrit.wikimedia.org/r/#/c/261611/

@Krinkle : For those of us who aren't intimately familiar with mediawiki, could you edit the description to more clearly explain what the "search label" is?

@ksmith: It's the <label> for the MediaWiki search field.

Change 297782 had a related patch set uploaded (by VolkerE):
Make role=search heading and label accessible

https://gerrit.wikimedia.org/r/297782

debt added a subscriber: debt.

removing the search tag - this is more of a front-end thing.

Change 297782 merged by jenkins-bot:
Make role=search heading and label accessible

https://gerrit.wikimedia.org/r/297782

matmarex closed this task as Resolved.Jul 22 2016, 6:47 PM
matmarex assigned this task to Volker_E.
matmarex edited projects, added Vector; removed Patch-For-Review.