Page MenuHomePhabricator
Create Task
Maniphest T139433

Page content is no longer showing with diffs
Closed, ResolvedPublic
Actions

Description

There is a regression, apparently new to 1.28.0-wmf.9 (I can reproduce on MediaWiki.org, but not on English Wikipedia.

Looks likely to be rMWb02bfac06b04: Adding a bunch of hooks from wikiHow into DifferenceEngine.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Show parser output for diffs unless extension abortsmediawiki/coremaster+1 -1
Show parser output for diffs unless extension abortsmediawiki/corewmf/1.28.0-wmf.9+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Jul 6 2016, 12:04 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 6 2016, 12:04 AM
gerritbot subscribed.Jul 6 2016, 12:09 AM

Change 297546 had a related patch set uploaded (by Mattflaschen):
Show parser output for diffs unless extension aborts

https://gerrit.wikimedia.org/r/297546

gerritbot added a project: Patch-For-Review.Jul 6 2016, 12:09 AM
Paladox added a parent task: T138555: MW-1.28.0-wmf.9 deployment blockers.Jul 6 2016, 12:15 AM
Paladox subscribed.
gerritbot added a comment.Jul 6 2016, 12:19 AM

Change 297547 had a related patch set uploaded (by Paladox):
Show parser output for diffs unless extension aborts

https://gerrit.wikimedia.org/r/297547

gerritbot added a comment.Jul 6 2016, 12:28 AM

Change 297546 merged by jenkins-bot:
Show parser output for diffs unless extension aborts

https://gerrit.wikimedia.org/r/297546

gerritbot added a comment.Jul 6 2016, 12:30 AM

Change 297547 merged by jenkins-bot:
Show parser output for diffs unless extension aborts

https://gerrit.wikimedia.org/r/297547

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 6 2016, 1:00 AM
Stashbot subscribed.Jul 6 2016, 3:18 PM

Mentioned in SAL [2016-07-06T15:18:42Z] <thcipriani@tin> Synchronized php-1.28.0-wmf.9/includes/diff/DifferenceEngine.php: [[gerrit:297547|Show parser output for diffs unless extension aborts (T139433)]] (duration: 00m 30s)

matmarex closed this task as Resolved.Jul 6 2016, 5:43 PM
matmarex assigned this task to • Mattflaschen-WMF.
matmarex subscribed.

Looks fixed and deployed. Thanks @Mattflaschen-WMF.

• Mattflaschen-WMF mentioned this in T139526: Catchable fatal error: Argument 1 passed to DifferenceEngine::generateContentDiffBody() must implement interface Content, null given.Jul 11 2016, 11:40 PM
Aklapper edited projects, added: MediaWiki-Page-history; removed: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits