have a phabricator test instance in labs that uses a working puppet role
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dzahn
	Jul 6 2016, 3:32 PM

Description

There is not a single instance in labs that uses the "production" OR the "labs" puppet role for phabricator. They fail for different reasons.

We should get to a place where at least the "labs" role can be applied, even better would be to use the same role as in production and not even have "labs" roles in the first place.

Manually setup phab-XX instances have limited usefulness for testing because we never know if they are like production at all and after every change in production they need to be manually synced (which is super error prone).

It has been said that phab2001 could be used for this, but i also see a conflict here. It can either be the failover host or the test/staging host, but probably not both at the same time.

Details

Project	Branch	Lines +/-	Subject
operations/puppet	production	+0 -71	phabricator: delete labs role
operations/puppet	production	+26 -4	Phabricator: Allow setting the mysql.user and mysql.pass in labs
operations/puppet	production	+16 -10	Phabricator: define vcs interfaces only when configured in hiera

Customize query in gerrit

Related Objects

Mentioned In: T152129: reinstall iridium (phabricator) as phab1001 with jessie
T127617: Upgrade phab-01.wmflabs.org
T139444: phab-01 and phab-03 to 04 returns a 502 error
Mentioned Here: P4527 Phabricator installation guide on labs

Event Timeline

Dzahn created this task.Jul 6 2016, 3:32 PM

Restricted Application added subscribers: Zppix, TerraCodes, Aklapper. · View Herald TranscriptJul 6 2016, 3:32 PM

Dzahn updated the task description. (Show Details)Jul 6 2016, 3:33 PM

Paladox added a subscriber: Paladox.Jul 6 2016, 3:33 PM

Dzahn mentioned this in T139444: phab-01 and phab-03 to 04 returns a 502 error.Jul 6 2016, 3:33 PM

Dzahn mentioned this in T127617: Upgrade phab-01.wmflabs.org.

Paladox added a subscriber: mmodell.Jul 10 2016, 11:17 AM

Danny_B edited projects, added VPS-project-Phabricator; removed Phabricator.Jul 12 2016, 12:12 PM

Change 322980 had a related patch set uploaded (by Paladox):
Make setting ipv6 optional in phabricator

https://gerrit.wikimedia.org/r/322980

gerritbot added a project: Patch-For-Review.Nov 22 2016, 10:09 PM

Also fixed in https://gerrit.wikimedia.org/r/#/c/322972/

Change 322980 merged by Dzahn:
Phabricator: define vcs interfaces only when configured in hiera

https://gerrit.wikimedia.org/r/322980

Change 323146 had a related patch set uploaded (by Paladox):
Phabricator: Allow setting the mysql.user and mysql.pass in labs

https://gerrit.wikimedia.org/r/323146

Change 323146 merged by Dzahn:
Phabricator: Allow setting the mysql.user and mysql.pass in labs

https://gerrit.wikimedia.org/r/323146

Patch https://gerrit.wikimedia.org/r/#/c/324408/ and https://gerrit.wikimedia.org/r/#/c/324551/ allows you to configure a different domain through heira.

This class is all working now.

Working domain is http://phabricator-01.wmflabs.org/ using this puppet class.

Paladox added a project: Phabricator.Dec 1 2016, 5:02 PM

Adding screenshot to show it working

CLosing as resolved, as it installs.

Creating a doc at

P4527 Phabricator installation guide on labs

1	I did this on Jessie so may be different on different distro's
2
3	1. apt-get install mariadb-server-10.1
4	(set password to something like phabricator)
5
6	2. go to https://horizon.wikimedia.org/project/proxy/ and create a web proxy domain (on port 80)
7
8	2. Add this to Heira:<project name> (example phabricator)
9
10	Note: Please change the ip to your instance ip otherwise this will not work, also change the domain name phabricator-01.wmflabs.org to your own domain which you created on step 2.
11
12	"role::deployment::repo_config":
13	phabricator/deployment:
14	upstream: https://gerrit.wikimedia.org/r/p/phabricator/deployment.git
15	deployment_server: localhost <-- keep localhost as changing this will fail in labs
16	"scap::deployment_server": localhost <-- keep localhost as scap will fail if you change this
17	"phabricator::trusted_proxies":
18	- 10.68.16.15
19	"scap::server::keyholder_agents":
20	phabricator:
21	trusted_groups:
22	- 'project-%{::labsproject}'
23	"scap::server::sources":
24	phabricator/deployment:
25	repository: phabricator/deployment
26	phabricator_servers:
27	- phabricator.phabricator.eqiad.wmflabs <-- change phabricator.phabricator to instance_name.project_name
28
29	"cache::misc::nodes":
30	eqiad:
31	- phabricator.phabricator.eqiad.wmflabs <-- change phabricator.phabricator to instance_name.project_name
32	"phabricator::vcs::address::v4":
33	- 10.68.16.15 <-- change ip to the ip of your instance
34	phabricator_app_user: root <-- change the MySQL user to the user you created in MySQL you choose
35	phabricator_app_pass: phabricator <-- change the pass to the pass you choose
36	phabricator_daemons_user: root <-- change the MySQL user to the user you created in MySQL you choose
37	phabricator_daemons_pass: phabricator <-- change the pass to the pass you choose
38	"phabricator::mysql_admin_user": root <-- change the MySQL user to the user you created in MySQL you choose
39	"phabricator::mysql_admin_pass": phabricator <-- change the pass to the pass you choose
40	phabricator_admin_user: root <-- change the MySQL user to the user you created in MySQL you choose
41	phabricator_admin_pass: phabricator <-- change the pass to the pass you choose
42	phabricator_domain: phabricator-01.wmflabs.org <-- change the domain you created on step 2
43	phabricator_altdomain: phabricator-01.wmflabs.org <-- change the domain you created on step 2
44	phabricator_diffusion_ssh_host: git-ssh.wmflabs.org
45	"phabricator::vcs::listen_addresses":
46	- 10.68.16.15 <-- change ip to the ip of your instance
47
48	3. add this role::phabricator::main puppet role to your instance.
49
50	4. then run sudo puppet agent -tv
51
52	5. cd /srv/phab/phabricator
53
54	6. bin/storage upgrade (when asked input yes)
55
56	7. you should now be able to access your domain
57
58	This is optional in case it does not work use this
59
60	export PHABRICATOR_ENV=phd
61
62	sudo -E bin/storage upgrade <-- command you run ie that

Can confirm we now have a jessie instance using the regular "role::phabricator::main" role and puppet run finishes without errors.

Paladox did the manual mariadb install on localhost but the rest is all from the prod role.

Very nice!

Linux phabricator 4.4.0-3-amd64 #1 SMP Debian 4.4.2-3+wmf7 (2016-11-04) x86_64
Debian GNU/Linux 8.6 (jessie)
phabricator is a Phabricator (Main) (role::phabricator::main)
The last Puppet run was at Thu Dec  1 18:56:10 UTC 2016 (26 minutes ago).

Dzahn awarded a token.Dec 1 2016, 7:32 PM

Dzahn edited projects, added SRE; removed Patch-For-Review.Dec 1 2016, 7:36 PM

Dzahn mentioned this in T152129: reinstall iridium (phabricator) as phab1001 with jessie.Dec 1 2016, 8:00 PM

Change 327690 had a related patch set uploaded (by Dzahn):
phabricator: delete labs role

https://gerrit.wikimedia.org/r/327690

gerritbot added a project: Patch-For-Review.Dec 16 2016, 2:02 AM

Change 327690 merged by Dzahn:
phabricator: delete labs role

https://gerrit.wikimedia.org/r/327690